linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings
@ 2016-06-07  3:27 Jia Hongtao
  2016-06-08 19:52 ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Jia Hongtao @ 2016-06-07  3:27 UTC (permalink / raw)
  To: edubezval, rui.zhang, robh+dt, galak, scott.wood, shawnguo
  Cc: linux-pm, devicetree, linux-kernel, linuxppc-dev,
	linux-arm-kernel, hongtao.jia

For different types of SoC the sensor id and endianness may vary.
"#thermal-sensor-cells" is used to provide sensor id information.
"little-endian" property is to tell the endianness of TMU.

Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
---
Changes for V2:
* Remove formatting chnages.

 Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
index 66223d5..20ca4ef 100644
--- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
@@ -17,6 +17,12 @@ Required properties:
 	calibration data, as specified by the SoC reference manual.
 	The first cell of each pair is the value to be written to TTCFGR,
 	and the second is the value to be written to TSCFGR.
+- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
+	site ID, and represents the "n" in TRITSRn and TRATSRn.
+
+Optional property:
+- little-endian : If present, the TMU registers are little endian. If absent,
+	the default is big endian.

 Example:

@@ -60,4 +66,5 @@ tmu@f0000 {

 			       0x00030000 0x00000012
 			       0x00030001 0x0000001d>;
+	#thermal-sensor-cells = <1>;
 };
--
2.1.0.27.g96db324

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings
  2016-06-07  3:27 [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
@ 2016-06-08 19:52 ` Rob Herring
  2016-09-14 16:40   ` Leo Li
  0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2016-06-08 19:52 UTC (permalink / raw)
  To: Jia Hongtao
  Cc: edubezval, rui.zhang, galak, scott.wood, shawnguo, linux-pm,
	devicetree, linux-kernel, linuxppc-dev, linux-arm-kernel

On Tue, Jun 07, 2016 at 11:27:34AM +0800, Jia Hongtao wrote:
> For different types of SoC the sensor id and endianness may vary.
> "#thermal-sensor-cells" is used to provide sensor id information.
> "little-endian" property is to tell the endianness of TMU.
> 
> Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> ---
> Changes for V2:
> * Remove formatting chnages.
> 
>  Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
>  1 file changed, 7 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings
  2016-06-08 19:52 ` Rob Herring
@ 2016-09-14 16:40   ` Leo Li
  2016-09-19  2:44     ` Zhang Rui
  0 siblings, 1 reply; 5+ messages in thread
From: Leo Li @ 2016-09-14 16:40 UTC (permalink / raw)
  To: Rob Herring, rui.zhang
  Cc: Jia Hongtao, devicetree, linux-pm, linuxppc-dev, lkml,
	Scott Wood, Eduardo Valentin, Kumar Gala, Shawn Guo,
	linux-arm-kernel

On Wed, Jun 8, 2016 at 2:52 PM, Rob Herring <robh@kernel.org> wrote:
> On Tue, Jun 07, 2016 at 11:27:34AM +0800, Jia Hongtao wrote:
>> For different types of SoC the sensor id and endianness may vary.
>> "#thermal-sensor-cells" is used to provide sensor id information.
>> "little-endian" property is to tell the endianness of TMU.
>>
>> Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
>> ---
>> Changes for V2:
>> * Remove formatting chnages.
>>
>>  Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
>>  1 file changed, 7 insertions(+)
>
> Acked-by: Rob Herring <robh@kernel.org>

Hi Zhang Rui,

Since you have applied the driver patch, can you also apply the
binding patch?  The binding is supposed to go with the driver.

Regards,
Leo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings
  2016-09-14 16:40   ` Leo Li
@ 2016-09-19  2:44     ` Zhang Rui
  2016-10-09  7:12       ` Troy Jia
  0 siblings, 1 reply; 5+ messages in thread
From: Zhang Rui @ 2016-09-19  2:44 UTC (permalink / raw)
  To: Leo Li, Rob Herring
  Cc: Jia Hongtao, devicetree, linux-pm, linuxppc-dev, lkml,
	Scott Wood, Eduardo Valentin, Kumar Gala, Shawn Guo,
	linux-arm-kernel

On 三, 2016-09-14 at 11:40 -0500, Leo Li wrote:
> On Wed, Jun 8, 2016 at 2:52 PM, Rob Herring <robh@kernel.org> wrote:
> > 
> > On Tue, Jun 07, 2016 at 11:27:34AM +0800, Jia Hongtao wrote:
> > > 
> > > For different types of SoC the sensor id and endianness may vary.
> > > "#thermal-sensor-cells" is used to provide sensor id information.
> > > "little-endian" property is to tell the endianness of TMU.
> > > 
> > > Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> > > ---
> > > Changes for V2:
> > > * Remove formatting chnages.
> > > 
> > >  Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7
> > > +++++++
> > >  1 file changed, 7 insertions(+)
> > Acked-by: Rob Herring <robh@kernel.org>
> Hi Zhang Rui,
> 
> Since you have applied the driver patch, can you also apply the
> binding patch?  The binding is supposed to go with the driver.
> 

Do you mean I should take both patch 1/7 and 7/7? I can not see the
other patches in this patch set.

thanks,
rui

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings
  2016-09-19  2:44     ` Zhang Rui
@ 2016-10-09  7:12       ` Troy Jia
  0 siblings, 0 replies; 5+ messages in thread
From: Troy Jia @ 2016-10-09  7:12 UTC (permalink / raw)
  To: Zhang Rui, Leo Li, Rob Herring
  Cc: devicetree, linux-pm, linuxppc-dev, lkml, Scott Wood,
	Eduardo Valentin, Kumar Gala, Shawn Guo, linux-arm-kernel

> -----Original Message-----
> From: Zhang Rui [mailto:rui.zhang@intel.com]
> Sent: Monday, September 19, 2016 10:44 AM
> To: Leo Li <pku.leo@gmail.com>; Rob Herring <robh@kernel.org>
> Cc: Troy Jia <hongtao.jia@nxp.com>; devicetree@vger.kernel.org; linux-
> pm@vger.kernel.org; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>; lkml <linux-
> kernel@vger.kernel.org>; Scott Wood <scott.wood@nxp.com>; Eduardo Valentin
> <edubezval@gmail.com>; Kumar Gala <galak@codeaurora.org>; Shawn Guo
> <shawnguo@kernel.org>; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings
> 
> On 三, 2016-09-14 at 11:40 -0500, Leo Li wrote:
> > On Wed, Jun 8, 2016 at 2:52 PM, Rob Herring <robh@kernel.org> wrote:
> > >
> > > On Tue, Jun 07, 2016 at 11:27:34AM +0800, Jia Hongtao wrote:
> > > >
> > > > For different types of SoC the sensor id and endianness may vary.
> > > > "#thermal-sensor-cells" is used to provide sensor id information.
> > > > "little-endian" property is to tell the endianness of TMU.
> > > >
> > > > Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> > > > ---
> > > > Changes for V2:
> > > > * Remove formatting chnages.
> > > >
> > > >  Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7
> > > > +++++++
> > > >  1 file changed, 7 insertions(+)
> > > Acked-by: Rob Herring <robh@kernel.org>
> > Hi Zhang Rui,
> >
> > Since you have applied the driver patch, can you also apply the
> > binding patch?  The binding is supposed to go with the driver.
> >
> 
> Do you mean I should take both patch 1/7 and 7/7? I can not see the other patches
> in this patch set.

Yes, please take 7/7 as well.
I also reworked the device tree patches and you can find them here:
https://patchwork.kernel.org/patch/9368377/
https://patchwork.kernel.org/patch/9368381/
https://patchwork.kernel.org/patch/9368383/
https://patchwork.kernel.org/patch/9368379/
https://patchwork.kernel.org/patch/9368385/

-Hongtao.

> 
> thanks,
> rui

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-10-09  9:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07  3:27 [PATCH V2 1/7] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
2016-06-08 19:52 ` Rob Herring
2016-09-14 16:40   ` Leo Li
2016-09-19  2:44     ` Zhang Rui
2016-10-09  7:12       ` Troy Jia

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).