* [PATCH 1/4] Staging: comedi: fix blank line issue in das16.c
@ 2016-06-07 8:36 Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 2/4] Staging: comedi: Block comment issue fixed for das16.c Ravishankar Karkala Mallikarjunayya
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ravishankar Karkala Mallikarjunayya @ 2016-06-07 8:36 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, ravishankarkm32
This is a patch to the das16.c file that fixes up a blank line after
function/struct/union/enum check found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das16.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c
index fd8e0b7..4d6e581 100644
--- a/drivers/staging/comedi/drivers/das16.c
+++ b/drivers/staging/comedi/drivers/das16.c
@@ -198,6 +198,7 @@ enum {
das16_pg_1601,
das16_pg_1602,
};
+
static const int *const das16_gainlists[] = {
NULL,
das16jr_gainlist,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/4] Staging: comedi: Block comment issue fixed for das16.c
2016-06-07 8:36 [PATCH 1/4] Staging: comedi: fix blank line issue in das16.c Ravishankar Karkala Mallikarjunayya
@ 2016-06-07 8:36 ` Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 3/4] Staging: comedi: fix comment issue fixed for das800.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 4/4] Staging: comedi: Prefer unsigned int instead of unsigned in das800.c Ravishankar Karkala Mallikarjunayya
2 siblings, 0 replies; 4+ messages in thread
From: Ravishankar Karkala Mallikarjunayya @ 2016-06-07 8:36 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, ravishankarkm32
This is a patch to the das16.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das16.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c
index 4d6e581..ef345dc 100644
--- a/drivers/staging/comedi/drivers/das16.c
+++ b/drivers/staging/comedi/drivers/das16.c
@@ -429,8 +429,10 @@ static const struct das16_board das16_boards[] = {
},
};
-/* Period for timer interrupt in jiffies. It's a function
- * to deal with possibility of dynamic HZ patches */
+/*
+ * Period for timer interrupt in jiffies. It's a function
+ * to deal with possibility of dynamic HZ patches
+ */
static inline int timer_period(void)
{
return HZ / 20;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 3/4] Staging: comedi: fix comment issue fixed for das800.c
2016-06-07 8:36 [PATCH 1/4] Staging: comedi: fix blank line issue in das16.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 2/4] Staging: comedi: Block comment issue fixed for das16.c Ravishankar Karkala Mallikarjunayya
@ 2016-06-07 8:36 ` Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 4/4] Staging: comedi: Prefer unsigned int instead of unsigned in das800.c Ravishankar Karkala Mallikarjunayya
2 siblings, 0 replies; 4+ messages in thread
From: Ravishankar Karkala Mallikarjunayya @ 2016-06-07 8:36 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, ravishankarkm32
This is a patch to the das800.c file that fixes up a
WARNING: 'Block comments use a trailing */ on a separate line'
found by the checkpatch.pl tool
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das800.c | 102 ++++++++++++++++----------------
1 file changed, 51 insertions(+), 51 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c
index b02f122..1f1b7ad 100644
--- a/drivers/staging/comedi/drivers/das800.c
+++ b/drivers/staging/comedi/drivers/das800.c
@@ -1,56 +1,56 @@
/*
- comedi/drivers/das800.c
- Driver for Keitley das800 series boards and compatibles
- Copyright (C) 2000 Frank Mori Hess <fmhess@users.sourceforge.net>
-
- COMEDI - Linux Control and Measurement Device Interface
- Copyright (C) 2000 David A. Schleef <ds@schleef.org>
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-*/
+ * comedi/drivers/das800.c
+ * Driver for Keitley das800 series boards and compatibles
+ * Copyright (C) 2000 Frank Mori Hess <fmhess@users.sourceforge.net>
+ *
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 2000 David A. Schleef <ds@schleef.org>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
/*
-Driver: das800
-Description: Keithley Metrabyte DAS800 (& compatibles)
-Author: Frank Mori Hess <fmhess@users.sourceforge.net>
-Devices: [Keithley Metrabyte] DAS-800 (das-800), DAS-801 (das-801),
- DAS-802 (das-802),
- [Measurement Computing] CIO-DAS800 (cio-das800),
- CIO-DAS801 (cio-das801), CIO-DAS802 (cio-das802),
- CIO-DAS802/16 (cio-das802/16)
-Status: works, cio-das802/16 untested - email me if you have tested it
-
-Configuration options:
- [0] - I/O port base address
- [1] - IRQ (optional, required for timed or externally triggered conversions)
-
-Notes:
- IRQ can be omitted, although the cmd interface will not work without it.
-
- All entries in the channel/gain list must use the same gain and be
- consecutive channels counting upwards in channel number (these are
- hardware limitations.)
-
- I've never tested the gain setting stuff since I only have a
- DAS-800 board with fixed gain.
-
- The cio-das802/16 does not have a fifo-empty status bit! Therefore
- only fifo-half-full transfers are possible with this card.
-
-cmd triggers supported:
- start_src: TRIG_NOW | TRIG_EXT
- scan_begin_src: TRIG_FOLLOW
- scan_end_src: TRIG_COUNT
- convert_src: TRIG_TIMER | TRIG_EXT
- stop_src: TRIG_NONE | TRIG_COUNT
-*/
+ * Driver: das800
+ * Description: Keithley Metrabyte DAS800 (& compatibles)
+ * Author: Frank Mori Hess <fmhess@users.sourceforge.net>
+ * Devices: [Keithley Metrabyte] DAS-800 (das-800), DAS-801 (das-801),
+ * DAS-802 (das-802),
+ * [Measurement Computing] CIO-DAS800 (cio-das800),
+ * CIO-DAS801 (cio-das801), CIO-DAS802 (cio-das802),
+ * CIO-DAS802/16 (cio-das802/16)
+ * Status: works, cio-das802/16 untested - email me if you have tested it
+ *
+ * Configuration options:
+ * [0] - I/O port base address
+ * [1] - IRQ (optional, required for timed or externally triggered conversions)
+ *
+ * Notes:
+ * IRQ can be omitted, although the cmd interface will not work without it.
+ *
+ * All entries in the channel/gain list must use the same gain and be
+ * consecutive channels counting upwards in channel number (these are
+ * hardware limitations.)
+ *
+ * I've never tested the gain setting stuff since I only have a
+ * DAS-800 board with fixed gain.
+ *
+ * The cio-das802/16 does not have a fifo-empty status bit! Therefore
+ * only fifo-half-full transfers are possible with this card.
+ *
+ * cmd triggers supported:
+ * start_src: TRIG_NOW | TRIG_EXT
+ * scan_begin_src: TRIG_FOLLOW
+ * scan_end_src: TRIG_COUNT
+ * convert_src: TRIG_TIMER | TRIG_EXT
+ * stop_src: TRIG_NONE | TRIG_COUNT
+ */
#include <linux/module.h>
#include <linux/interrupt.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 4/4] Staging: comedi: Prefer unsigned int instead of unsigned in das800.c
2016-06-07 8:36 [PATCH 1/4] Staging: comedi: fix blank line issue in das16.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 2/4] Staging: comedi: Block comment issue fixed for das16.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 3/4] Staging: comedi: fix comment issue fixed for das800.c Ravishankar Karkala Mallikarjunayya
@ 2016-06-07 8:36 ` Ravishankar Karkala Mallikarjunayya
2 siblings, 0 replies; 4+ messages in thread
From: Ravishankar Karkala Mallikarjunayya @ 2016-06-07 8:36 UTC (permalink / raw)
To: abbotti, hsweeten, gregkh; +Cc: devel, linux-kernel, ravishankarkm32
This is a patch to the das800.c file that fixes up a
WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
found by the checkpatch.pl tool.
Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/das800.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c
index 1f1b7ad..fd4cb49 100644
--- a/drivers/staging/comedi/drivers/das800.c
+++ b/drivers/staging/comedi/drivers/das800.c
@@ -218,7 +218,7 @@ struct das800_private {
};
static void das800_ind_write(struct comedi_device *dev,
- unsigned val, unsigned reg)
+ unsigned int val, unsigned int reg)
{
/*
* Select dev->iobase + 2 to be desired register
@@ -228,7 +228,7 @@ static void das800_ind_write(struct comedi_device *dev,
outb(val, dev->iobase + 2);
}
-static unsigned das800_ind_read(struct comedi_device *dev, unsigned reg)
+static unsigned int das800_ind_read(struct comedi_device *dev, unsigned int reg)
{
/*
* Select dev->iobase + 7 to be desired register
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-07 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-07 8:36 [PATCH 1/4] Staging: comedi: fix blank line issue in das16.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 2/4] Staging: comedi: Block comment issue fixed for das16.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 3/4] Staging: comedi: fix comment issue fixed for das800.c Ravishankar Karkala Mallikarjunayya
2016-06-07 8:36 ` [PATCH 4/4] Staging: comedi: Prefer unsigned int instead of unsigned in das800.c Ravishankar Karkala Mallikarjunayya
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).