From: Paul Bolle <pebolle@tiscali.nl>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test
Date: Wed, 08 Jun 2016 21:42:40 +0200 [thread overview]
Message-ID: <1465414960.12598.29.camel@tiscali.nl> (raw)
In-Reply-To: <1465305402.26524.6.camel@mtksdaap41>
On di, 2016-06-07 at 21:16 +0800, Yingjoe Chen wrote:
> On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote:
> > > Is it obvious that a Kconfig has "default n" ?
> > > This seems to work, but is this useful?
>
> While sending patch for upstream, I saw maintainers request it to be
> removed. So I think it might worth adding check to it.
> Some examples from google:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-September/1
> 20733.html
> https://lkml.org/lkml/2013/3/16/153
> https://lkml.org/lkml/2016/5/23/657
There's one rather subtle case where setting "default n" is, sort of,
useful. See lkml.kernel.org/r/<178407860.0zoJnDfCo1@tacticalops> .
(I seem to remember disagreeing here. Ie, in my view setting defaults
for a specific Kconfig symbol at two different places is confusing at
best. People probably weren't convinced by my objections. I also
remember diving into this by looking at the various places where a
Kconfig symbol was being set twice. I must have ended that endeavor when
it became clear to me I was't making any progress.)
Even though there's a corner case where "default n" is useful, it could
still be worth to add a checkpatch check that warns about it. But I
can't say I feel strongly about this either way.
Paul Bolle
prev parent reply other threads:[~2016-06-08 19:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 5:10 [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Yingjoe Chen
2016-06-04 5:10 ` [PATCH v3 2/2] checkpatch: testing more config for Kconfig help text Yingjoe Chen
2016-06-06 16:43 ` [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Joe Perches
2016-06-06 19:10 ` Andy Whitcroft
2016-06-07 13:16 ` Yingjoe Chen
2016-06-08 19:42 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465414960.12598.29.camel@tiscali.nl \
--to=pebolle@tiscali.nl \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).