From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>,
Andi Kleen <ak@linux.intel.com>, Paul Bolle <pebolle@tiscali.nl>
Subject: Re: [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test
Date: Tue, 7 Jun 2016 21:16:42 +0800 [thread overview]
Message-ID: <1465305402.26524.6.camel@mtksdaap41> (raw)
In-Reply-To: <20160606191047.GK18360@brain>
Hi,
Thanks for the review.
On Mon, 2016-06-06 at 20:10 +0100, Andy Whitcroft wrote:
> On Mon, Jun 06, 2016 at 09:43:15AM -0700, Joe Perches wrote:
> > On Sat, 2016-06-04 at 13:10 +0800, Yingjoe Chen wrote:
> > > If a Kconfig config option doesn't specify 'default', the default
> > > will be n. Adding 'default n' is unnecessary.
> > > Add a test to warn about this.
> >
> > Is it obvious that a Kconfig has "default n" ?
> > This seems to work, but is this useful?
While sending patch for upstream, I saw maintainers request it to be
removed. So I think it might worth adding check to it.
Some examples from google:
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-September/120733.html
https://lkml.org/lkml/2013/3/16/153
https://lkml.org/lkml/2016/5/23/657
>
> > > + if ($realfile =~ /Kconfig/ &&
> > > + $line =~ /^\+\s*default\s*n\s*(#.*|$)/i) {
>
> I wonder particually when the submitter has supplied a comment, presumably
> to tell us why it defaults to 'n'. I feel more accepting of rejecting
> uncommented ones than those with.
How about change this to /^\+\s*default\s*n$/i ?
Joe.C
next prev parent reply other threads:[~2016-06-07 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 5:10 [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Yingjoe Chen
2016-06-04 5:10 ` [PATCH v3 2/2] checkpatch: testing more config for Kconfig help text Yingjoe Chen
2016-06-06 16:43 ` [PATCH v3 1/2] checkpatch: add Kconfig 'default n' test Joe Perches
2016-06-06 19:10 ` Andy Whitcroft
2016-06-07 13:16 ` Yingjoe Chen [this message]
2016-06-08 19:42 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465305402.26524.6.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).