linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] virtio_net: Update the feature bit to comply with spec
@ 2016-06-09 17:41 Aaron Conole
  2016-06-10  6:35 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Aaron Conole @ 2016-06-09 17:41 UTC (permalink / raw)
  To: netdev, Michael S. Tsirkin, virtualization, linux-kernel

A draft version of the MTU Advice feature bit was specified as 25.  This
bit is not within the allowed range for network device feature bits, and
should be changed to be feature bit 3 to fully comply with the spec.

Fixes 14de9d114a82 ('virtio-net: Add initial MTU advice feature')
Signed-off-by: Aaron Conole <aconole@redhat.com>
Suggested-by: "Michael S. Tsirkin" <mst@redhat.com>
---
 include/uapi/linux/virtio_net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h
index 1ab4ea6..0da0e3a 100644
--- a/include/uapi/linux/virtio_net.h
+++ b/include/uapi/linux/virtio_net.h
@@ -35,6 +35,7 @@
 #define VIRTIO_NET_F_CSUM	0	/* Host handles pkts w/ partial csum */
 #define VIRTIO_NET_F_GUEST_CSUM	1	/* Guest handles pkts w/ partial csum */
 #define VIRTIO_NET_F_CTRL_GUEST_OFFLOADS 2 /* Dynamic offload configuration. */
+#define VIRTIO_NET_F_MTU	3	/* Initial MTU advice */
 #define VIRTIO_NET_F_MAC	5	/* Host has given MAC address. */
 #define VIRTIO_NET_F_GUEST_TSO4	7	/* Guest can handle TSOv4 in. */
 #define VIRTIO_NET_F_GUEST_TSO6	8	/* Guest can handle TSOv6 in. */
@@ -55,7 +56,6 @@
 #define VIRTIO_NET_F_MQ	22	/* Device supports Receive Flow
 					 * Steering */
 #define VIRTIO_NET_F_CTRL_MAC_ADDR 23	/* Set MAC address */
-#define VIRTIO_NET_F_MTU 25	/* Initial MTU advice */
 
 #ifndef VIRTIO_NET_NO_LEGACY
 #define VIRTIO_NET_F_GSO	6	/* Host handles pkts w/ any GSO type */
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] virtio_net: Update the feature bit to comply with spec
  2016-06-09 17:41 [PATCH -next] virtio_net: Update the feature bit to comply with spec Aaron Conole
@ 2016-06-10  6:35 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-06-10  6:35 UTC (permalink / raw)
  To: aconole; +Cc: netdev, mst, virtualization, linux-kernel

From: Aaron Conole <aconole@redhat.com>
Date: Thu,  9 Jun 2016 13:41:15 -0400

> A draft version of the MTU Advice feature bit was specified as 25.  This
> bit is not within the allowed range for network device feature bits, and
> should be changed to be feature bit 3 to fully comply with the spec.
> 
> Fixes 14de9d114a82 ('virtio-net: Add initial MTU advice feature')
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> Suggested-by: "Michael S. Tsirkin" <mst@redhat.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-10  6:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 17:41 [PATCH -next] virtio_net: Update the feature bit to comply with spec Aaron Conole
2016-06-10  6:35 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).