* [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module
@ 2016-06-14 21:20 Javier Martinez Canillas
2016-06-20 8:57 ` Sjoerd Simons
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2016-06-14 21:20 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Arnd Bergmann, Thierry Reding,
Krzysztof Kozlowski, Sjoerd Simons, Lee Jones, Chen-Yu Tsai,
Olof Johansson, Russell King, linux-arm-kernel, Simon Horman
The driver is for a trackpad device so is not needed for booting and
makes more sense to have it as module to reduce the kernel image size.
It was probably enabled as built-in because module autoload was not
working when the I2C device was registered by OF but this got fixed
in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C
table for module autoload") so it's safe to enable as a module now.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index ee7c884ab5d8..c29bdd070721 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -269,7 +269,7 @@ CONFIG_MOUSE_PS2_ELANTECH=y
CONFIG_MOUSE_CYAPA=m
CONFIG_MOUSE_ELAN_I2C=y
CONFIG_INPUT_TOUCHSCREEN=y
-CONFIG_TOUCHSCREEN_ATMEL_MXT=y
+CONFIG_TOUCHSCREEN_ATMEL_MXT=m
CONFIG_TOUCHSCREEN_MMS114=m
CONFIG_TOUCHSCREEN_ST1232=m
CONFIG_TOUCHSCREEN_STMPE=y
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module
2016-06-14 21:20 [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module Javier Martinez Canillas
@ 2016-06-20 8:57 ` Sjoerd Simons
0 siblings, 0 replies; 2+ messages in thread
From: Sjoerd Simons @ 2016-06-20 8:57 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Arnd Bergmann, Thierry Reding, Krzysztof Kozlowski, Lee Jones,
Chen-Yu Tsai, Olof Johansson, Russell King, linux-arm-kernel,
Simon Horman
Hey,
On Tue, 2016-06-14 at 17:20 -0400, Javier Martinez Canillas wrote:
> The driver is for a trackpad device so is not needed for booting and
> makes more sense to have it as module to reduce the kernel image
> size.
>
> It was probably enabled as built-in because module autoload was not
> working when the I2C device was registered by OF but this got fixed
> in commit b7d21058b40b ("Input: atmel_mxt_ts - add maxtouch to I2C
> table for module autoload") so it's safe to enable as a module now.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Make sense to me,
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>
> arch/arm/configs/multi_v7_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig
> index ee7c884ab5d8..c29bdd070721 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -269,7 +269,7 @@ CONFIG_MOUSE_PS2_ELANTECH=y
> CONFIG_MOUSE_CYAPA=m
> CONFIG_MOUSE_ELAN_I2C=y
> CONFIG_INPUT_TOUCHSCREEN=y
> -CONFIG_TOUCHSCREEN_ATMEL_MXT=y
> +CONFIG_TOUCHSCREEN_ATMEL_MXT=m
> CONFIG_TOUCHSCREEN_MMS114=m
> CONFIG_TOUCHSCREEN_ST1232=m
> CONFIG_TOUCHSCREEN_STMPE=y
--
Sjoerd Simons
Collabora Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-20 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-14 21:20 [PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module Javier Martinez Canillas
2016-06-20 8:57 ` Sjoerd Simons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).