* [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks
@ 2016-06-19 20:29 Ruslan Bilovol
2016-06-20 1:30 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Ruslan Bilovol @ 2016-06-19 20:29 UTC (permalink / raw)
To: apw, joe; +Cc: linux-kernel, keescook
Config EXPERIMENTAL has been removed from kernel in 2013
(see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
there is no any reason to do these checks now.
Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
---
scripts/checkpatch.pl | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4904ced..4ede92c 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2670,13 +2670,6 @@ sub process {
#print "is_start<$is_start> is_end<$is_end> length<$length>\n";
}
-# discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
- if ($realfile =~ /Kconfig/ &&
- $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
- WARN("CONFIG_EXPERIMENTAL",
- "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
- }
-
# discourage the use of boolean for type definition attributes of Kconfig options
if ($realfile =~ /Kconfig/ &&
$line =~ /^\+\s*\bboolean\b/) {
@@ -3042,12 +3035,6 @@ sub process {
}
}
-# discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
- if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
- WARN("CONFIG_EXPERIMENTAL",
- "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
- }
-
# check for RCS/CVS revision markers
if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
WARN("CVS_KEYWORD",
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks
2016-06-19 20:29 [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Ruslan Bilovol
@ 2016-06-20 1:30 ` Joe Perches
2016-06-20 2:15 ` Ruslan Bilovol
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2016-06-20 1:30 UTC (permalink / raw)
To: Ruslan Bilovol, apw; +Cc: linux-kernel, keescook
On Sun, 2016-06-19 at 23:29 +0300, Ruslan Bilovol wrote:
> Config EXPERIMENTAL has been removed from kernel in 2013
> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
> there is no any reason to do these checks now.
Not quite removed:
$ git grep CONFIG_EXPERIMENTAL -- "*configs*" | wc -l
217
No objection from me though.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks
2016-06-20 1:30 ` Joe Perches
@ 2016-06-20 2:15 ` Ruslan Bilovol
0 siblings, 0 replies; 3+ messages in thread
From: Ruslan Bilovol @ 2016-06-20 2:15 UTC (permalink / raw)
To: Joe Perches; +Cc: Robo Bot, linux-kernel, keescook
On Mon, Jun 20, 2016 at 4:30 AM, Joe Perches <joe@perches.com> wrote:
> On Sun, 2016-06-19 at 23:29 +0300, Ruslan Bilovol wrote:
>> Config EXPERIMENTAL has been removed from kernel in 2013
>> (see 3d374d0: "final removal of CONFIG_EXPERIMENTAL"),
>> there is no any reason to do these checks now.
>
> Not quite removed:
>
> $ git grep CONFIG_EXPERIMENTAL -- "*configs*" | wc -l
> 217
I just mean that config option is removed from Kconfig file.
These checkpatch checks have nothing to do with
"CONFIG_EXPERIMENTAL=y" lines that still live in many
defconfigs.
BTW, I can write quite simple script that will remove it from
defconfig as well and send to related maintainers in a
separate patch series, or alternatively you can do similar
thing proposed by you in RFC https://lkml.org/lkml/2015/7/16/725
>
> No objection from me though.
Thanks
Best regards,
Ruslan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-20 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-19 20:29 [PATCH] checkpatch: remove obsolete CONFIG_EXPERIMENTAL checks Ruslan Bilovol
2016-06-20 1:30 ` Joe Perches
2016-06-20 2:15 ` Ruslan Bilovol
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).