* [BUG] au0828: dev->lock in au0828_usb_probe()
@ 2016-06-22 23:11 Alexey Khoroshilov
0 siblings, 0 replies; only message in thread
From: Alexey Khoroshilov @ 2016-06-22 23:11 UTC (permalink / raw)
To: Shuah Khan, Mauro Carvalho Chehab
Cc: Alexey Khoroshilov, linux-media, linux-kernel, ldv-project
It is not quite clear what does mutex_lock(&dev->lock) defend against.
If there is a chance that some other code can try to lock the mutex during probe(),
then
mutex_unlock(&dev->lock);
kfree(dev);
looks suspicious, because when that code get control form mutex_lock(dev->lock)
the dev could be already freed.
Otherwise, dev->lock should not be acquired so early.
Another problem is that on the path going via goto done
there is no mutex_unlock(&dev->lock).
Found by Linux Driver Verification project (linuxtesting.org).
--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-06-22 23:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-22 23:11 [BUG] au0828: dev->lock in au0828_usb_probe() Alexey Khoroshilov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).