From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/6] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe()
Date: Thu, 23 Jun 2016 11:32:20 +0530 [thread overview]
Message-ID: <1466661744-3629-3-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1466661744-3629-1-git-send-email-kishon@ti.com>
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
In case of error, the function devm_kzalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/phy/phy-rockchip-dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/phy-rockchip-dp.c b/drivers/phy/phy-rockchip-dp.c
index 793ecb6..8b267a7 100644
--- a/drivers/phy/phy-rockchip-dp.c
+++ b/drivers/phy/phy-rockchip-dp.c
@@ -90,7 +90,7 @@ static int rockchip_dp_phy_probe(struct platform_device *pdev)
return -ENODEV;
dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
- if (IS_ERR(dp))
+ if (!dp)
return -ENOMEM;
dp->dev = dev;
--
1.7.9.5
next prev parent reply other threads:[~2016-06-23 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 6:02 [GIT PULL] phy: for 4.7 -rc cycle Kishon Vijay Abraham I
2016-06-23 6:02 ` [PATCH 1/6] phy: rcar-gen3-usb2: fix unexpected repeat interrupts of VBUS change Kishon Vijay Abraham I
2016-06-23 6:02 ` Kishon Vijay Abraham I [this message]
2016-06-23 6:02 ` [PATCH 3/6] phy: phy-sun4i-usb: Fix optional gpios failing probe Kishon Vijay Abraham I
2016-06-23 6:02 ` [PATCH 4/6] phy-sun4i-usb: fix missing __iomem * Kishon Vijay Abraham I
2016-06-23 6:02 ` [PATCH 5/6] phy: bcm-ns-usb2: checking the wrong variable Kishon Vijay Abraham I
2016-06-23 6:02 ` [PATCH 6/6] phy-sun4i-usb: Fix irq free conditions to match request conditions Kishon Vijay Abraham I
2016-06-25 0:02 ` [GIT PULL] phy: for 4.7 -rc cycle Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466661744-3629-3-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).