linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: <gregkh@linuxfoundation.org>
Cc: <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 5/6] phy: bcm-ns-usb2: checking the wrong variable
Date: Thu, 23 Jun 2016 11:32:23 +0530	[thread overview]
Message-ID: <1466661744-3629-6-git-send-email-kishon@ti.com> (raw)
In-Reply-To: <1466661744-3629-1-git-send-email-kishon@ti.com>

From: Dan Carpenter <dan.carpenter@oracle.com>

We intended to test "usb2->phy" here instead of "dev".

Fixes: d3feb4067335 ('phy: bcm-ns-usb2: new driver for USB 2.0 PHY on Northstar')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/phy/phy-bcm-ns-usb2.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/phy-bcm-ns-usb2.c b/drivers/phy/phy-bcm-ns-usb2.c
index 95ab6b2..58dff80 100644
--- a/drivers/phy/phy-bcm-ns-usb2.c
+++ b/drivers/phy/phy-bcm-ns-usb2.c
@@ -109,8 +109,8 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
 	}
 
 	usb2->phy = devm_phy_create(dev, NULL, &ops);
-	if (IS_ERR(dev))
-		return PTR_ERR(dev);
+	if (IS_ERR(usb2->phy))
+		return PTR_ERR(usb2->phy);
 
 	phy_set_drvdata(usb2->phy, usb2);
 	platform_set_drvdata(pdev, usb2);
-- 
1.7.9.5

  parent reply	other threads:[~2016-06-23  6:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-23  6:02 [GIT PULL] phy: for 4.7 -rc cycle Kishon Vijay Abraham I
2016-06-23  6:02 ` [PATCH 1/6] phy: rcar-gen3-usb2: fix unexpected repeat interrupts of VBUS change Kishon Vijay Abraham I
2016-06-23  6:02 ` [PATCH 2/6] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe() Kishon Vijay Abraham I
2016-06-23  6:02 ` [PATCH 3/6] phy: phy-sun4i-usb: Fix optional gpios failing probe Kishon Vijay Abraham I
2016-06-23  6:02 ` [PATCH 4/6] phy-sun4i-usb: fix missing __iomem * Kishon Vijay Abraham I
2016-06-23  6:02 ` Kishon Vijay Abraham I [this message]
2016-06-23  6:02 ` [PATCH 6/6] phy-sun4i-usb: Fix irq free conditions to match request conditions Kishon Vijay Abraham I
2016-06-25  0:02 ` [GIT PULL] phy: for 4.7 -rc cycle Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466661744-3629-6-git-send-email-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).