* [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
@ 2016-06-23 17:48 Colin King
2016-06-23 19:00 ` Eli Billauer
2016-06-23 19:05 ` Joe Perches
0 siblings, 2 replies; 6+ messages in thread
From: Colin King @ 2016-06-23 17:48 UTC (permalink / raw)
To: Eli Billauer, Greg Kroah-Hartman; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
trivial fix to spelling mistake in dev_err message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/char/xillybus/xillybus_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
index dcd19f3..8586a85 100644
--- a/drivers/char/xillybus/xillybus_core.c
+++ b/drivers/char/xillybus/xillybus_core.c
@@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
/* Check version number. Accept anything below 0x82 for now. */
if (*version > 0x82) {
dev_err(endpoint->dev,
- "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
+ "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
*version);
return -ENODEV;
}
--
2.8.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
2016-06-23 17:48 [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" Colin King
@ 2016-06-23 19:00 ` Eli Billauer
2016-06-23 19:05 ` Joe Perches
1 sibling, 0 replies; 6+ messages in thread
From: Eli Billauer @ 2016-06-23 19:00 UTC (permalink / raw)
To: Colin King; +Cc: Greg Kroah-Hartman, linux-kernel
I stand corrected. Thanks.
Acked-by: Eli Billauer <eli.billauer@gmail.com>
On 23/06/16 20:48, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> trivial fix to spelling mistake in dev_err message
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
> drivers/char/xillybus/xillybus_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
> index dcd19f3..8586a85 100644
> --- a/drivers/char/xillybus/xillybus_core.c
> +++ b/drivers/char/xillybus/xillybus_core.c
> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
> /* Check version number. Accept anything below 0x82 for now. */
> if (*version> 0x82) {
> dev_err(endpoint->dev,
> - "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
> + "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
> *version);
> return -ENODEV;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
2016-06-23 17:48 [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" Colin King
2016-06-23 19:00 ` Eli Billauer
@ 2016-06-23 19:05 ` Joe Perches
2016-06-23 19:23 ` Eli Billauer
1 sibling, 1 reply; 6+ messages in thread
From: Joe Perches @ 2016-06-23 19:05 UTC (permalink / raw)
To: Colin King, Eli Billauer, Greg Kroah-Hartman; +Cc: linux-kernel
On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
> trivial fix to spelling mistake in dev_err message
[]
> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
[]
> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
> /* Check version number. Accept anything below 0x82 for now. */
> if (*version > 0x82) {
trivia: code doesn't match comment above it.
> dev_err(endpoint->dev,
> - "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
> + "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
> *version);
> return -ENODEV;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
2016-06-23 19:05 ` Joe Perches
@ 2016-06-23 19:23 ` Eli Billauer
2016-06-23 19:51 ` Colin Ian King
0 siblings, 1 reply; 6+ messages in thread
From: Eli Billauer @ 2016-06-23 19:23 UTC (permalink / raw)
To: Joe Perches; +Cc: Colin King, Greg Kroah-Hartman, linux-kernel
This is getting increasingly embarrassing. I suppose a single patch,
fixing both silly mistakes (of mine), would be in place.
Colin, would you prefer to submit a patch with both issues fixed
yourself, or should I take care of it?
Thanks, both of you.
Eli
On 23/06/16 22:05, Joe Perches wrote:
> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>
>> trivial fix to spelling mistake in dev_err message
>>
> []
>
>> diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c
>>
> []
>
>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint *endpoint)
>> /* Check version number. Accept anything below 0x82 for now. */
>> if (*version> 0x82) {
>>
> trivia: code doesn't match comment above it.
>
>
>> dev_err(endpoint->dev,
>> - "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgarde. Aborting.\n",
>> + "No support for IDT version 0x%02x. Maybe the xillybus driver needs an upgrade. Aborting.\n",
>> *version);
>> return -ENODEV;
>> }
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
2016-06-23 19:23 ` Eli Billauer
@ 2016-06-23 19:51 ` Colin Ian King
2016-06-23 20:09 ` Eli Billauer
0 siblings, 1 reply; 6+ messages in thread
From: Colin Ian King @ 2016-06-23 19:51 UTC (permalink / raw)
To: Eli Billauer, Joe Perches; +Cc: Greg Kroah-Hartman, linux-kernel
On 23/06/16 20:23, Eli Billauer wrote:
> This is getting increasingly embarrassing. I suppose a single patch,
> fixing both silly mistakes (of mine), would be in place.
>
> Colin, would you prefer to submit a patch with both issues fixed
> yourself, or should I take care of it?
Eli, I don't mind if you fix it up.
>
> Thanks, both of you.
> Eli
>
> On 23/06/16 22:05, Joe Perches wrote:
>> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>>
>>> trivial fix to spelling mistake in dev_err message
>>>
>> []
>>
>>> diff --git a/drivers/char/xillybus/xillybus_core.c
>>> b/drivers/char/xillybus/xillybus_core.c
>>>
>> []
>>
>>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint
>>> *endpoint)
>>> /* Check version number. Accept anything below 0x82 for now. */
>>> if (*version> 0x82) {
>>>
>> trivia: code doesn't match comment above it.
>>
>>
>>> dev_err(endpoint->dev,
>>> - "No support for IDT version 0x%02x. Maybe the xillybus
>>> driver needs an upgarde. Aborting.\n",
>>> + "No support for IDT version 0x%02x. Maybe the xillybus
>>> driver needs an upgrade. Aborting.\n",
>>> *version);
>>> return -ENODEV;
>>> }
>>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade"
2016-06-23 19:51 ` Colin Ian King
@ 2016-06-23 20:09 ` Eli Billauer
0 siblings, 0 replies; 6+ messages in thread
From: Eli Billauer @ 2016-06-23 20:09 UTC (permalink / raw)
To: Colin Ian King, Joe Perches; +Cc: Greg Kroah-Hartman, linux-kernel
OK, I'll submit a patch quite soon. Thanks again.
Eli
On 23/06/16 22:51, Colin Ian King wrote:
> On 23/06/16 20:23, Eli Billauer wrote:
>
>> This is getting increasingly embarrassing. I suppose a single patch,
>> fixing both silly mistakes (of mine), would be in place.
>>
>> Colin, would you prefer to submit a patch with both issues fixed
>> yourself, or should I take care of it?
>>
> Eli, I don't mind if you fix it up.
>
>
>> Thanks, both of you.
>> Eli
>>
>> On 23/06/16 22:05, Joe Perches wrote:
>>
>>> On Thu, 2016-06-23 at 18:48 +0100, Colin King wrote:
>>>
>>>
>>>> trivial fix to spelling mistake in dev_err message
>>>>
>>>>
>>> []
>>>
>>>
>>>> diff --git a/drivers/char/xillybus/xillybus_core.c
>>>> b/drivers/char/xillybus/xillybus_core.c
>>>>
>>>>
>>> []
>>>
>>>
>>>> @@ -658,7 +658,7 @@ static int xilly_obtain_idt(struct xilly_endpoint
>>>> *endpoint)
>>>> /* Check version number. Accept anything below 0x82 for now. */
>>>> if (*version> 0x82) {
>>>>
>>>>
>>> trivia: code doesn't match comment above it.
>>>
>>>
>>>
>>>> dev_err(endpoint->dev,
>>>> - "No support for IDT version 0x%02x. Maybe the xillybus
>>>> driver needs an upgarde. Aborting.\n",
>>>> + "No support for IDT version 0x%02x. Maybe the xillybus
>>>> driver needs an upgrade. Aborting.\n",
>>>> *version);
>>>> return -ENODEV;
>>>> }
>>>>
>>>>
>>>
>>>
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-06-23 20:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-23 17:48 [PATCH] char: xillybus: fix spelling mistake: "upgarde" -> "upgrade" Colin King
2016-06-23 19:00 ` Eli Billauer
2016-06-23 19:05 ` Joe Perches
2016-06-23 19:23 ` Eli Billauer
2016-06-23 19:51 ` Colin Ian King
2016-06-23 20:09 ` Eli Billauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).