linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keerthy <j-keerthy@ti.com>
To: <lee.jones@linaro.org>, <tony@atomide.com>, <broonie@kernel.org>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<t-kristo@ti.com>, <russ.dill@ti.com>, <j-keerthy@ti.com>,
	Dave Gerlach <d-gerlach@ti.com>
Subject: [PATCH v2 5/5] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs
Date: Fri, 24 Jun 2016 13:58:11 +0530	[thread overview]
Message-ID: <1466756892-17015-5-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1466756892-17015-1-git-send-email-j-keerthy@ti.com>

From: Tero Kristo <t-kristo@ti.com>

Some versions of tps65218 do not seem to support poweroff modes properly
if DCDC3 regulator is shut-down. Thus, keep it enabled even during
poweroff if the version info matches the broken silicon revision.

Signed-off-by: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/regulator/tps65218-regulator.c | 8 ++++++++
 include/linux/mfd/tps65218.h           | 5 +++++
 2 files changed, 13 insertions(+)

diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c
index d1e631d..eb0f5b1 100644
--- a/drivers/regulator/tps65218-regulator.c
+++ b/drivers/regulator/tps65218-regulator.c
@@ -180,6 +180,14 @@ static int tps65218_pmic_set_suspend_disable(struct regulator_dev *dev)
 	if (rid < TPS65218_DCDC_1 || rid > TPS65218_LDO_1)
 		return -EINVAL;
 
+	/*
+	 * Certain revisions of TPS65218 will need to have DCDC3 regulator
+	 * enabled always, otherwise an immediate system reboot will occur
+	 * during poweroff.
+	 */
+	if (rid == TPS65218_DCDC_3 && tps->rev == TPS65218_REV_2_1)
+		return 0;
+
 	if (!tps->info[rid]->strobe) {
 		if (rid == TPS65218_DCDC_3)
 			tps->info[rid]->strobe = 3;
diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h
index 85e464e..d1db952 100644
--- a/include/linux/mfd/tps65218.h
+++ b/include/linux/mfd/tps65218.h
@@ -63,6 +63,11 @@
 #define TPS65218_CHIPID_CHIP_MASK	0xF8
 #define TPS65218_CHIPID_REV_MASK	0x07
 
+#define TPS65218_REV_1_0		0x0
+#define TPS65218_REV_1_1		0x1
+#define TPS65218_REV_2_0		0x2
+#define TPS65218_REV_2_1		0x3
+
 #define TPS65218_INT1_VPRG		BIT(5)
 #define TPS65218_INT1_AC		BIT(4)
 #define TPS65218_INT1_PB		BIT(3)
-- 
1.9.1

  parent reply	other threads:[~2016-06-24  8:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-24  8:28 [PATCH v2 1/5] regulator: tps65217: Enable suspend configuration Keerthy
2016-06-24  8:28 ` [PATCH v2 2/5] regulator: tps65218: " Keerthy
2016-06-24  8:28 ` [PATCH v2 3/5] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3 Keerthy
2016-06-24  8:28 ` [PATCH v2 4/5] mfd: tps65218: add version check to the PMIC probe Keerthy
2016-06-28 11:14   ` Lee Jones
2016-06-24  8:28 ` Keerthy [this message]
2016-06-27 16:59   ` [PATCH v2 5/5] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Mark Brown
2016-06-28  9:28     ` Keerthy
2016-06-28 11:12     ` Lee Jones
2016-06-28 11:13       ` Lee Jones
2016-06-28 11:24         ` Keerthy
2016-06-28 11:45           ` Lee Jones
2016-06-24  8:28 ` [PATCH v2 0/5] regulator: Enable suspend configuration Keerthy
2016-06-27 17:00 ` Applied "regulator: tps65217: Enable suspend configuration" to the regulator tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466756892-17015-5-git-send-email-j-keerthy@ti.com \
    --to=j-keerthy@ti.com \
    --cc=broonie@kernel.org \
    --cc=d-gerlach@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=russ.dill@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).