From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <j-keerthy@ti.com>
Cc: tony@atomide.com, broonie@kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, t-kristo@ti.com, russ.dill@ti.com,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH v2 4/5] mfd: tps65218: add version check to the PMIC probe
Date: Tue, 28 Jun 2016 12:14:02 +0100 [thread overview]
Message-ID: <20160628111402.GA24982@dell> (raw)
In-Reply-To: <1466756892-17015-4-git-send-email-j-keerthy@ti.com>
On Fri, 24 Jun 2016, Keerthy wrote:
> From: Tero Kristo <t-kristo@ti.com>
>
> Version information will be needed to handle some error cases under the
> regulator driver, so store the information once during MFD probe.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> drivers/mfd/tps65218.c | 9 +++++++++
> include/linux/mfd/tps65218.h | 1 +
> 2 files changed, 10 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
> index 80b9dc3..ba610ad 100644
> --- a/drivers/mfd/tps65218.c
> +++ b/drivers/mfd/tps65218.c
> @@ -219,6 +219,7 @@ static int tps65218_probe(struct i2c_client *client,
> struct tps65218 *tps;
> const struct of_device_id *match;
> int ret;
> + unsigned int chipid;
>
> match = of_match_device(of_tps65218_match_table, &client->dev);
> if (!match) {
> @@ -250,6 +251,14 @@ static int tps65218_probe(struct i2c_client *client,
> if (ret < 0)
> return ret;
>
> + ret = tps65218_reg_read(tps, TPS65218_REG_CHIPID, &chipid);
> + if (ret) {
> + dev_err(tps->dev, "Failed to read chipid: %d\n", ret);
> + return ret;
> + }
> +
> + tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
> +
> ret = of_platform_populate(client->dev.of_node, NULL, NULL,
> &client->dev);
> if (ret < 0)
> diff --git a/include/linux/mfd/tps65218.h b/include/linux/mfd/tps65218.h
> index 7fdf532..85e464e 100644
> --- a/include/linux/mfd/tps65218.h
> +++ b/include/linux/mfd/tps65218.h
> @@ -267,6 +267,7 @@ struct tps_info {
> struct tps65218 {
> struct device *dev;
> unsigned int id;
> + u8 rev;
>
> struct mutex tps_lock; /* lock guarding the data structure */
> /* IRQ Data */
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-06-28 11:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 8:28 [PATCH v2 1/5] regulator: tps65217: Enable suspend configuration Keerthy
2016-06-24 8:28 ` [PATCH v2 2/5] regulator: tps65218: " Keerthy
2016-06-24 8:28 ` [PATCH v2 3/5] regulator: tps65218: force set power-up/down strobe to 3 for dcdc3 Keerthy
2016-06-24 8:28 ` [PATCH v2 4/5] mfd: tps65218: add version check to the PMIC probe Keerthy
2016-06-28 11:14 ` Lee Jones [this message]
2016-06-24 8:28 ` [PATCH v2 5/5] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs Keerthy
2016-06-27 16:59 ` Mark Brown
2016-06-28 9:28 ` Keerthy
2016-06-28 11:12 ` Lee Jones
2016-06-28 11:13 ` Lee Jones
2016-06-28 11:24 ` Keerthy
2016-06-28 11:45 ` Lee Jones
2016-06-24 8:28 ` [PATCH v2 0/5] regulator: Enable suspend configuration Keerthy
2016-06-27 17:00 ` Applied "regulator: tps65217: Enable suspend configuration" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160628111402.GA24982@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=russ.dill@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).