* [PATCH] clk: stm32f4: fix error handling
@ 2016-07-03 6:06 Christophe JAILLET
2016-07-07 0:55 ` Michael Turquette
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2016-07-03 6:06 UTC (permalink / raw)
To: mturquette, sboyd, mcoquelin.stm32
Cc: linux-clk, linux-arm-kernel, linux-kernel, kernel-janitors,
Christophe JAILLET
This is likely that checking 'clks[idx]' instead of 'clks[n]' is
expected here.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/clk/clk-stm32f4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index b6ca33f..02d6810 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -364,7 +364,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
NULL, gd->name, gd->parent_name, gd->flags,
base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
- if (IS_ERR(clks[n])) {
+ if (IS_ERR(clks[idx])) {
pr_err("%s: Unable to register leaf clock %s\n",
np->full_name, gd->name);
goto fail;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: stm32f4: fix error handling
2016-07-03 6:06 [PATCH] clk: stm32f4: fix error handling Christophe JAILLET
@ 2016-07-07 0:55 ` Michael Turquette
0 siblings, 0 replies; 2+ messages in thread
From: Michael Turquette @ 2016-07-07 0:55 UTC (permalink / raw)
To: Christophe JAILLET, sboyd, mcoquelin.stm32
Cc: linux-clk, linux-arm-kernel, linux-kernel, kernel-janitors,
Christophe JAILLET
Quoting Christophe JAILLET (2016-07-02 23:06:43)
> This is likely that checking 'clks[idx]' instead of 'clks[n]' is
> expected here.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied.
Regards,
Mike
> ---
> drivers/clk/clk-stm32f4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
> index b6ca33f..02d6810 100644
> --- a/drivers/clk/clk-stm32f4.c
> +++ b/drivers/clk/clk-stm32f4.c
> @@ -364,7 +364,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
> NULL, gd->name, gd->parent_name, gd->flags,
> base + gd->offset, gd->bit_idx, 0, &stm32f4_clk_lock);
>
> - if (IS_ERR(clks[n])) {
> + if (IS_ERR(clks[idx])) {
> pr_err("%s: Unable to register leaf clock %s\n",
> np->full_name, gd->name);
> goto fail;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-07 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 6:06 [PATCH] clk: stm32f4: fix error handling Christophe JAILLET
2016-07-07 0:55 ` Michael Turquette
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).