* [PATCH] rtc: m41t80: use devm_add_action_or_reset()
@ 2016-07-03 20:18 Sudip Mukherjee
2016-07-19 15:31 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2016-07-03 20:18 UTC (permalink / raw)
To: Alessandro Zummo, Alexandre Belloni
Cc: linux-kernel, rtc-linux, Sudip Mukherjee
If devm_add_action() fails we are explicitly calling the cleanup to free
the resources allocated. Lets use the helper devm_add_action_or_reset()
and return directly in case of error, as we know that the cleanup function
has been already called by the helper if there was any error.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
drivers/rtc/rtc-m41t80.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index d1bf93a..49bc464 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -831,10 +831,9 @@ static int m41t80_probe(struct i2c_client *client,
return rc;
}
- rc = devm_add_action(&client->dev, m41t80_remove_sysfs_group,
- &client->dev);
+ rc = devm_add_action_or_reset(&client->dev, m41t80_remove_sysfs_group,
+ &client->dev);
if (rc) {
- m41t80_remove_sysfs_group(&client->dev);
dev_err(&client->dev,
"Failed to add sysfs cleanup action: %d\n", rc);
return rc;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: m41t80: use devm_add_action_or_reset()
2016-07-03 20:18 [PATCH] rtc: m41t80: use devm_add_action_or_reset() Sudip Mukherjee
@ 2016-07-19 15:31 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2016-07-19 15:31 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Alessandro Zummo, linux-kernel, rtc-linux
On 03/07/2016 at 21:18:58 +0100, Sudip Mukherjee wrote :
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated. Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup function
> has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
> drivers/rtc/rtc-m41t80.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-19 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-03 20:18 [PATCH] rtc: m41t80: use devm_add_action_or_reset() Sudip Mukherjee
2016-07-19 15:31 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).