* [PATCH] clocksource: cadence_ttc: fix a return value in case of error
@ 2016-07-06 5:35 Christophe JAILLET
2016-07-06 15:33 ` Sören Brinkmann
2016-07-07 7:46 ` Daniel Lezcano
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2016-07-06 5:35 UTC (permalink / raw)
To: michal.simek, soren.brinkmann, daniel.lezcano, tglx
Cc: linux-arm-kernel, linux-kernel, kernel-janitors, Christophe JAILLET
IS_ERR and PTR_ERR should use the same variable, clk_ce in this case.
Fixes: 4de1eb07c47f (Convert init function to return error)
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/clocksource/cadence_ttc_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/cadence_ttc_timer.c b/drivers/clocksource/cadence_ttc_timer.c
index 388a77b..fbfbdec 100644
--- a/drivers/clocksource/cadence_ttc_timer.c
+++ b/drivers/clocksource/cadence_ttc_timer.c
@@ -523,7 +523,7 @@ static int __init ttc_timer_init(struct device_node *timer)
clk_ce = of_clk_get(timer, clksel);
if (IS_ERR(clk_ce)) {
pr_err("ERROR: timer input clock not found\n");
- return PTR_ERR(clk_cs);
+ return PTR_ERR(clk_ce);
}
ret = ttc_setup_clocksource(clk_cs, timer_baseaddr, timer_width);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error
2016-07-06 5:35 [PATCH] clocksource: cadence_ttc: fix a return value in case of error Christophe JAILLET
@ 2016-07-06 15:33 ` Sören Brinkmann
2016-07-07 7:46 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Sören Brinkmann @ 2016-07-06 15:33 UTC (permalink / raw)
To: Christophe JAILLET
Cc: michal.simek, daniel.lezcano, tglx, linux-arm-kernel,
linux-kernel, kernel-janitors
On Wed, 2016-07-06 at 07:35:23 +0200, Christophe JAILLET wrote:
> IS_ERR and PTR_ERR should use the same variable, clk_ce in this case.
>
> Fixes: 4de1eb07c47f (Convert init function to return error)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Sören Brinkmann <soren.brinkmann@xilinx.com>
Sören
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error
2016-07-06 5:35 [PATCH] clocksource: cadence_ttc: fix a return value in case of error Christophe JAILLET
2016-07-06 15:33 ` Sören Brinkmann
@ 2016-07-07 7:46 ` Daniel Lezcano
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Lezcano @ 2016-07-07 7:46 UTC (permalink / raw)
To: Christophe JAILLET
Cc: michal.simek, soren.brinkmann, tglx, linux-arm-kernel,
linux-kernel, kernel-janitors
On Wed, Jul 06, 2016 at 07:35:23AM +0200, Christophe JAILLET wrote:
> IS_ERR and PTR_ERR should use the same variable, clk_ce in this case.
>
> Fixes: 4de1eb07c47f (Convert init function to return error)
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied, thanks.
-- Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-07 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-06 5:35 [PATCH] clocksource: cadence_ttc: fix a return value in case of error Christophe JAILLET
2016-07-06 15:33 ` Sören Brinkmann
2016-07-07 7:46 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).