From: Tim Harvey <tharvey@gateworks.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] i2c: imx: add retries for i2c-0 on Ventana boards
Date: Thu, 7 Jul 2016 07:03:49 -0700 [thread overview]
Message-ID: <1467900229-5262-1-git-send-email-tharvey@gateworks.com> (raw)
Gateworks Ventana IMX6 based boards have a Gateworks System Controller [1]
(gsc) device that can NAK i2c transactions when its busy in an ADC loop. As
this is always on i2c-0 we will add retries for that bus for any Ventana
board.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
drivers/i2c/busses/i2c-imx.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 1844bc9..aec71c3 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -460,6 +460,8 @@ static int i2c_imx_acked(struct imx_i2c_struct *i2c_imx)
{
if (imx_i2c_read_reg(i2c_imx, IMX_I2C_I2SR) & I2SR_RXAK) {
dev_dbg(&i2c_imx->adapter.dev, "<%s> No ACK\n", __func__);
+ if (i2c_imx->adapter.retries)
+ return -EAGAIN;
return -ENXIO; /* No ACK */
}
@@ -1068,6 +1070,16 @@ static int i2c_imx_probe(struct platform_device *pdev)
i2c_imx->adapter.dev.of_node = pdev->dev.of_node;
i2c_imx->base = base;
+ /*
+ * The Gateworks Ventana has an i2c based system controller on i2c-0
+ * which emulates several standard i2c devices with existing drivers.
+ * That device can NAK when its in an ADC loop. Add bus retries.
+ */
+ if (of_machine_is_compatible("gw,ventana") && phy_addr == 0x021a0000) {
+ dev_info(&pdev->dev, "Adding retries for Ventana GSC\n");
+ i2c_imx->adapter.retries = 3;
+ }
+
/* Get I2C clock */
i2c_imx->clk = devm_clk_get(&pdev->dev, NULL);
if (IS_ERR(i2c_imx->clk)) {
--
1.9.1
next reply other threads:[~2016-07-07 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 14:03 Tim Harvey [this message]
2016-07-08 6:28 ` [PATCH] i2c: imx: add retries for i2c-0 on Ventana boards Uwe Kleine-König
2016-07-08 19:49 ` Tim Harvey
2016-07-08 21:07 ` Uwe Kleine-König
2016-07-09 2:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467900229-5262-1-git-send-email-tharvey@gateworks.com \
--to=tharvey@gateworks.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).