From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Tim Harvey <tharvey@gateworks.com>, Wolfram Sang <wsa@the-dreams.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
linux-i2c@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: imx: add retries for i2c-0 on Ventana boards
Date: Fri, 8 Jul 2016 23:07:14 +0200 [thread overview]
Message-ID: <20160708210714.GK16643@pengutronix.de> (raw)
In-Reply-To: <CAJ+vNU2QLTh7-tbLB_b2S04+pMg3VFjN2kk8T2d6x1okdmbx1A@mail.gmail.com>
Hello Tim, hello Wolfram,
On Fri, Jul 08, 2016 at 12:49:04PM -0700, Tim Harvey wrote:
> On Thu, Jul 7, 2016 at 11:28 PM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > Hello Tim,
> >
> > On Thu, Jul 07, 2016 at 07:03:49AM -0700, Tim Harvey wrote:
> >> Gateworks Ventana IMX6 based boards have a Gateworks System Controller [1]
> >> (gsc) device that can NAK i2c transactions when its busy in an ADC loop. As
> >> this is always on i2c-0 we will add retries for that bus for any Ventana
> >> board.
> >
> > The right thing is to fix the drivers IMHO.
> >
> The issue I have is that the i2c device emulates several other devices
> with existing drivers (pca953x, ds1672, at24) and those drivers don't
> have any retry mechanism in place for a retry.
>
> Maybe if I converted those drivers to use regmap I could implement a
> regmap with retries in the mfd driver for my device?
Wolfram: what do you think?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-07-08 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 14:03 [PATCH] i2c: imx: add retries for i2c-0 on Ventana boards Tim Harvey
2016-07-08 6:28 ` Uwe Kleine-König
2016-07-08 19:49 ` Tim Harvey
2016-07-08 21:07 ` Uwe Kleine-König [this message]
2016-07-09 2:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708210714.GK16643@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=fabio.estevam@freescale.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).