linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	David Airlie <airlied@linux.ie>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: [PATCH v6 13/46] drm/mediatek: dma-mapping: Use unsigned long for dma_attrs
Date: Wed, 13 Jul 2016 10:41:04 +0200	[thread overview]
Message-ID: <1468399300-5399-13-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1468399300-5399-12-git-send-email-k.kozlowski@samsung.com>

Split out subsystem specific changes for easier reviews. This will be
squashed with main commit.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
[for drm]
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/mediatek/mtk_drm_gem.c | 13 ++++++-------
 drivers/gpu/drm/mediatek/mtk_drm_gem.h |  2 +-
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index fa2ec0cd00e8..7abc550ebc00 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -54,15 +54,14 @@ struct mtk_drm_gem_obj *mtk_drm_gem_create(struct drm_device *dev,
 
 	obj = &mtk_gem->base;
 
-	init_dma_attrs(&mtk_gem->dma_attrs);
-	dma_set_attr(DMA_ATTR_WRITE_COMBINE, &mtk_gem->dma_attrs);
+	mtk_gem->dma_attrs = DMA_ATTR_WRITE_COMBINE;
 
 	if (!alloc_kmap)
-		dma_set_attr(DMA_ATTR_NO_KERNEL_MAPPING, &mtk_gem->dma_attrs);
+		mtk_gem->dma_attrs |= DMA_ATTR_NO_KERNEL_MAPPING;
 
 	mtk_gem->cookie = dma_alloc_attrs(priv->dma_dev, obj->size,
 					  &mtk_gem->dma_addr, GFP_KERNEL,
-					  &mtk_gem->dma_attrs);
+					  mtk_gem->dma_attrs);
 	if (!mtk_gem->cookie) {
 		DRM_ERROR("failed to allocate %zx byte dma buffer", obj->size);
 		ret = -ENOMEM;
@@ -93,7 +92,7 @@ void mtk_drm_gem_free_object(struct drm_gem_object *obj)
 		drm_prime_gem_destroy(obj, mtk_gem->sg);
 	else
 		dma_free_attrs(priv->dma_dev, obj->size, mtk_gem->cookie,
-			       mtk_gem->dma_addr, &mtk_gem->dma_attrs);
+			       mtk_gem->dma_addr, mtk_gem->dma_attrs);
 
 	/* release file pointer to gem object. */
 	drm_gem_object_release(obj);
@@ -173,7 +172,7 @@ static int mtk_drm_gem_object_mmap(struct drm_gem_object *obj,
 	vma->vm_pgoff = 0;
 
 	ret = dma_mmap_attrs(priv->dma_dev, vma, mtk_gem->cookie,
-			     mtk_gem->dma_addr, obj->size, &mtk_gem->dma_attrs);
+			     mtk_gem->dma_addr, obj->size, mtk_gem->dma_attrs);
 	if (ret)
 		drm_gem_vm_close(vma);
 
@@ -224,7 +223,7 @@ struct sg_table *mtk_gem_prime_get_sg_table(struct drm_gem_object *obj)
 
 	ret = dma_get_sgtable_attrs(priv->dma_dev, sgt, mtk_gem->cookie,
 				    mtk_gem->dma_addr, obj->size,
-				    &mtk_gem->dma_attrs);
+				    mtk_gem->dma_attrs);
 	if (ret) {
 		DRM_ERROR("failed to allocate sgt, %d\n", ret);
 		kfree(sgt);
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.h b/drivers/gpu/drm/mediatek/mtk_drm_gem.h
index 3a2a5624a1cb..2752718fa5b2 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.h
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.h
@@ -35,7 +35,7 @@ struct mtk_drm_gem_obj {
 	void			*cookie;
 	void			*kvaddr;
 	dma_addr_t		dma_addr;
-	struct dma_attrs	dma_attrs;
+	unsigned long		dma_attrs;
 	struct sg_table		*sg;
 };
 
-- 
1.9.1

  reply	other threads:[~2016-07-13  8:42 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  8:39 [PATCH v6 00/46] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-07-13  8:40 ` [PATCH v6 01/46] [media] mtk-vcodec: Remove unused dma_attrs Krzysztof Kozlowski
2016-07-13  8:40   ` [PATCH v6 02/46] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-07-13  8:40     ` [PATCH v6 03/46] alpha: " Krzysztof Kozlowski
2016-07-13  8:40       ` [PATCH v6 04/46] arc: " Krzysztof Kozlowski
2016-07-13  8:40         ` [PATCH v6 05/46] ARM: " Krzysztof Kozlowski
2016-07-13  8:40           ` [PATCH v6 06/46] arm64: " Krzysztof Kozlowski
2016-07-13  8:40             ` [PATCH v6 07/46] avr32: " Krzysztof Kozlowski
2016-07-13  8:40               ` [PATCH v6 08/46] blackfin: " Krzysztof Kozlowski
2016-07-13  8:41                 ` [PATCH v6 09/46] c6x: " Krzysztof Kozlowski
2016-07-13  8:41                   ` [PATCH v6 10/46] cris: " Krzysztof Kozlowski
2016-07-13  8:41                     ` [PATCH v6 11/46] frv: " Krzysztof Kozlowski
2016-07-13  8:41                       ` [PATCH v6 12/46] drm/exynos: " Krzysztof Kozlowski
2016-07-13  8:41                         ` Krzysztof Kozlowski [this message]
2016-07-13  8:41                           ` [PATCH v6 14/46] drm/msm: " Krzysztof Kozlowski
2016-07-13  8:41                             ` [PATCH v6 15/46] drm/nouveau: " Krzysztof Kozlowski
2016-07-13  8:41                               ` [PATCH v6 16/46] drm/rockship: " Krzysztof Kozlowski
2016-07-13  8:41                                 ` [PATCH v6 17/46] infiniband: " Krzysztof Kozlowski
2016-07-13  8:41                                   ` [PATCH v6 18/46] iommu: " Krzysztof Kozlowski
2016-07-13  8:41                                     ` [PATCH v6 19/46] [media] " Krzysztof Kozlowski
2016-07-13  8:41                                       ` [PATCH v6 20/46] xen: " Krzysztof Kozlowski
2016-07-13  8:41                                         ` [PATCH v6 21/46] swiotlb: " Krzysztof Kozlowski
2016-07-13  8:41                                           ` [PATCH v6 22/46] powerpc: " Krzysztof Kozlowski
2016-07-13  8:41                                             ` [PATCH v6 23/46] video: " Krzysztof Kozlowski
2016-07-13  8:41                                               ` [PATCH v6 24/46] x86: " Krzysztof Kozlowski
2016-07-13  8:41                                                 ` [PATCH v6 25/46] iommu: intel: " Krzysztof Kozlowski
2016-07-13  8:41                                                   ` [PATCH v6 26/46] h8300: " Krzysztof Kozlowski
2016-07-13  8:41                                                     ` [PATCH v6 27/46] hexagon: " Krzysztof Kozlowski
2016-07-13  8:41                                                       ` [PATCH v6 28/46] ia64: " Krzysztof Kozlowski
2016-07-13  8:41                                                         ` [PATCH v6 29/46] m68k: " Krzysztof Kozlowski
2016-07-13  8:41                                                           ` [PATCH v6 30/46] metag: " Krzysztof Kozlowski
2016-07-13  8:41                                                             ` [PATCH v6 31/46] microblaze: " Krzysztof Kozlowski
2016-07-13  8:41                                                               ` [PATCH v6 32/46] mips: " Krzysztof Kozlowski
2016-07-13  8:41                                                                 ` [PATCH v6 33/46] mn10300: " Krzysztof Kozlowski
2016-07-13  8:41                                                                   ` [PATCH v6 34/46] nios2: " Krzysztof Kozlowski
2016-07-13  8:41                                                                     ` [PATCH v6 35/46] openrisc: " Krzysztof Kozlowski
2016-07-13  8:41                                                                       ` [PATCH v6 36/46] parisc: " Krzysztof Kozlowski
2016-07-13  8:41                                                                         ` [PATCH v6 37/46] misc: mic: " Krzysztof Kozlowski
2016-07-13  8:41                                                                           ` [PATCH v6 38/46] s390: " Krzysztof Kozlowski
2016-07-13  8:41                                                                             ` [PATCH v6 39/46] sh: " Krzysztof Kozlowski
2016-07-13  8:41                                                                               ` [PATCH v6 40/46] sparc: " Krzysztof Kozlowski
2016-07-13  8:41                                                                                 ` [PATCH v6 41/46] tile: " Krzysztof Kozlowski
2016-07-13  8:41                                                                                   ` [PATCH v6 42/46] unicore32: " Krzysztof Kozlowski
2016-07-13  8:41                                                                                     ` [PATCH v6 43/46] xtensa: " Krzysztof Kozlowski
2016-07-13  8:41                                                                                       ` [PATCH v6 44/46] remoteproc: qcom: " Krzysztof Kozlowski
2016-07-13  8:41                                                                                         ` [PATCH v6 45/46] dma-mapping: Remove dma_get_attr Krzysztof Kozlowski
2016-07-13  8:41                                                                                           ` [PATCH v6 46/46] dma-mapping: Document the DMA attributes next to the declaration Krzysztof Kozlowski
2016-07-13 16:51                                                                                         ` [PATCH v6 44/46] remoteproc: qcom: Use unsigned long for dma_attrs Bjorn Andersson
2016-07-13 10:37                                   ` [PATCH v6 17/46] infiniband: dma-mapping: " Bart Van Assche
2016-07-13 10:47                                     ` Krzysztof Kozlowski
2016-07-13 10:56                                       ` Bart Van Assche
2016-07-13 11:03                                         ` Krzysztof Kozlowski
2016-07-13 11:14                                   ` [PATCH v6.1] " Krzysztof Kozlowski
2016-07-13 11:17                                     ` Krzysztof Kozlowski
2016-07-13 11:56                                   ` [PATCH v6.2] " Krzysztof Kozlowski
2016-07-13 12:29                                     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468399300-5399-13-git-send-email-k.kozlowski@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).