From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Rob Clark <robdclark@gmail.com>, David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: [PATCH v6 14/46] drm/msm: dma-mapping: Use unsigned long for dma_attrs
Date: Wed, 13 Jul 2016 10:41:05 +0200 [thread overview]
Message-ID: <1468399300-5399-14-git-send-email-k.kozlowski@samsung.com> (raw)
In-Reply-To: <1468399300-5399-13-git-send-email-k.kozlowski@samsung.com>
Split out subsystem specific changes for easier reviews. This will be
squashed with main commit.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
[for drm]
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
---
drivers/gpu/drm/msm/msm_drv.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
index 108f9d4876b9..95b99f6b8826 100644
--- a/drivers/gpu/drm/msm/msm_drv.c
+++ b/drivers/gpu/drm/msm/msm_drv.c
@@ -238,11 +238,10 @@ static int msm_drm_uninit(struct device *dev)
}
if (priv->vram.paddr) {
- DEFINE_DMA_ATTRS(attrs);
- dma_set_attr(DMA_ATTR_NO_KERNEL_MAPPING, &attrs);
+ unsigned long attrs = DMA_ATTR_NO_KERNEL_MAPPING;
drm_mm_takedown(&priv->vram.mm);
dma_free_attrs(dev, priv->vram.size, NULL,
- priv->vram.paddr, &attrs);
+ priv->vram.paddr, attrs);
}
component_unbind_all(dev, ddev);
@@ -310,21 +309,21 @@ static int msm_init_vram(struct drm_device *dev)
}
if (size) {
- DEFINE_DMA_ATTRS(attrs);
+ unsigned long attrs = 0;
void *p;
priv->vram.size = size;
drm_mm_init(&priv->vram.mm, 0, (size >> PAGE_SHIFT) - 1);
- dma_set_attr(DMA_ATTR_NO_KERNEL_MAPPING, &attrs);
- dma_set_attr(DMA_ATTR_WRITE_COMBINE, &attrs);
+ attrs |= DMA_ATTR_NO_KERNEL_MAPPING;
+ attrs |= DMA_ATTR_WRITE_COMBINE;
/* note that for no-kernel-mapping, the vaddr returned
* is bogus, but non-null if allocation succeeded:
*/
p = dma_alloc_attrs(dev->dev, size,
- &priv->vram.paddr, GFP_KERNEL, &attrs);
+ &priv->vram.paddr, GFP_KERNEL, attrs);
if (!p) {
dev_err(dev->dev, "failed to allocate VRAM\n");
priv->vram.paddr = 0;
--
1.9.1
next prev parent reply other threads:[~2016-07-13 8:42 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 8:39 [PATCH v6 00/46] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 01/46] [media] mtk-vcodec: Remove unused dma_attrs Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 02/46] dma-mapping: Use unsigned long for dma_attrs Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 03/46] alpha: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 04/46] arc: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 05/46] ARM: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 06/46] arm64: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 07/46] avr32: " Krzysztof Kozlowski
2016-07-13 8:40 ` [PATCH v6 08/46] blackfin: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 09/46] c6x: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 10/46] cris: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 11/46] frv: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 12/46] drm/exynos: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 13/46] drm/mediatek: " Krzysztof Kozlowski
2016-07-13 8:41 ` Krzysztof Kozlowski [this message]
2016-07-13 8:41 ` [PATCH v6 15/46] drm/nouveau: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 16/46] drm/rockship: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 17/46] infiniband: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 18/46] iommu: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 19/46] [media] " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 20/46] xen: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 21/46] swiotlb: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 22/46] powerpc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 23/46] video: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 24/46] x86: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 25/46] iommu: intel: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 26/46] h8300: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 27/46] hexagon: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 28/46] ia64: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 29/46] m68k: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 30/46] metag: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 31/46] microblaze: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 32/46] mips: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 33/46] mn10300: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 34/46] nios2: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 35/46] openrisc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 36/46] parisc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 37/46] misc: mic: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 38/46] s390: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 39/46] sh: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 40/46] sparc: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 41/46] tile: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 42/46] unicore32: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 43/46] xtensa: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 44/46] remoteproc: qcom: " Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 45/46] dma-mapping: Remove dma_get_attr Krzysztof Kozlowski
2016-07-13 8:41 ` [PATCH v6 46/46] dma-mapping: Document the DMA attributes next to the declaration Krzysztof Kozlowski
2016-07-13 16:51 ` [PATCH v6 44/46] remoteproc: qcom: Use unsigned long for dma_attrs Bjorn Andersson
2016-07-13 10:37 ` [PATCH v6 17/46] infiniband: dma-mapping: " Bart Van Assche
2016-07-13 10:47 ` Krzysztof Kozlowski
2016-07-13 10:56 ` Bart Van Assche
2016-07-13 11:03 ` Krzysztof Kozlowski
2016-07-13 11:14 ` [PATCH v6.1] " Krzysztof Kozlowski
2016-07-13 11:17 ` Krzysztof Kozlowski
2016-07-13 11:56 ` [PATCH v6.2] " Krzysztof Kozlowski
2016-07-13 12:29 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468399300-5399-14-git-send-email-k.kozlowski@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=airlied@linux.ie \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).