From: Quentin Schulz <quentin.schulz@free-electrons.com>
To: jdelvare@suse.com, linux@roeck-us.net, jic23@kernel.org,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
maxime.ripard@free-electrons.com, wens@csie.org,
lee.jones@linaro.org
Cc: Quentin Schulz <quentin.schulz@free-electrons.com>,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@free-electrons.com,
antoine.tenart@free-electrons.com
Subject: [PATCH v3 3/4] mfd: mfd-core: reattach mfd of_node to cells without of_compatible
Date: Tue, 26 Jul 2016 09:43:46 +0200 [thread overview]
Message-ID: <1469519027-11387-4-git-send-email-quentin.schulz@free-electrons.com> (raw)
In-Reply-To: <1469519027-11387-1-git-send-email-quentin.schulz@free-electrons.com>
When an MFD cell has an of_compatible (meaning it is present in the Device
Tree), other nodes can reference it using a phandle.
However when the MFD cell is not declared in the Device Tree, the only way
other nodes can reference it are by using a phandle to the MFD. Then when
this MFD cell tries to register itself in one framework, the registration
is denied by the framework because it is not matching the of_node of the
node which is referenced by the phandle in one of the other nodes.
This reattaches the of_node of the MFD to the MFD cell device structure
when the MFD cell has no of_compatible.
Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
---
We need this modification to register the thermal sensor in the thermal
framework.
Added in v3.
drivers/mfd/mfd-core.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 3ac486a..0b19663 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -175,12 +175,16 @@ static int mfd_add_device(struct device *parent, int id,
if (ret < 0)
goto fail_res;
- if (parent->of_node && cell->of_compatible) {
- for_each_child_of_node(parent->of_node, np) {
- if (of_device_is_compatible(np, cell->of_compatible)) {
- pdev->dev.of_node = np;
- break;
+ if (parent->of_node) {
+ if (cell->of_compatible) {
+ for_each_child_of_node(parent->of_node, np) {
+ if (of_device_is_compatible(np, cell->of_compatible)) {
+ pdev->dev.of_node = np;
+ break;
+ }
}
+ } else {
+ pdev->dev.of_node = parent->of_node;
}
}
--
2.5.0
next prev parent reply other threads:[~2016-07-26 7:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 7:43 [PATCH v3 0/4] add support for Allwinner SoCs ADC Quentin Schulz
2016-07-26 7:43 ` [PATCH v3 1/4] hwmon: iio_hwmon: delay probing with late_initcall Quentin Schulz
2016-07-26 7:48 ` Thomas Petazzoni
2016-07-26 7:55 ` Quentin Schulz
2016-07-26 8:21 ` Alexander Stein
2016-07-26 8:24 ` Quentin Schulz
2016-07-26 9:05 ` Alexander Stein
2016-07-26 9:33 ` Quentin Schulz
2016-07-26 10:00 ` Alexander Stein
2016-07-26 10:07 ` Quentin Schulz
2016-07-26 16:04 ` Guenter Roeck
2016-08-15 15:40 ` Jonathan Cameron
2016-08-15 17:07 ` Guenter Roeck
2016-08-15 21:35 ` Jonathan Cameron
2016-09-01 7:15 ` Quentin Schulz
2016-09-01 9:03 ` Quentin Schulz
2016-09-03 19:32 ` Jonathan Cameron
2016-08-15 15:36 ` Jonathan Cameron
2016-07-26 7:43 ` [PATCH v3 2/4] mfd: add support for Allwinner SoCs ADC Quentin Schulz
2016-07-29 6:49 ` Maxime Ripard
2016-07-26 7:43 ` Quentin Schulz [this message]
2016-08-09 13:48 ` [PATCH v3 3/4] mfd: mfd-core: reattach mfd of_node to cells without of_compatible Lee Jones
2016-08-24 6:38 ` Maxime Ripard
2016-08-31 11:56 ` Lee Jones
2016-09-01 8:35 ` Quentin Schulz
2016-07-26 7:43 ` [PATCH v3 4/4] iio: adc: add support for Allwinner SoCs ADC Quentin Schulz
2016-07-29 7:12 ` Maxime Ripard
2016-08-04 8:41 ` Quentin Schulz
2016-08-24 6:41 ` Maxime Ripard
2016-08-04 9:56 ` Russell King - ARM Linux
2016-08-04 10:27 ` Quentin Schulz
2016-08-21 19:27 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469519027-11387-4-git-send-email-quentin.schulz@free-electrons.com \
--to=quentin.schulz@free-electrons.com \
--cc=antoine.tenart@free-electrons.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=pmeerw@pmeerw.net \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).