From: <Mario_Limonciello@Dell.com>
To: <pali.rohar@gmail.com>, <dvhart@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s
Date: Wed, 27 Jul 2016 15:55:09 +0000 [thread overview]
Message-ID: <1469634909478.10239@Dell.com> (raw)
In-Reply-To: <20160727072350.GF29844@pali>
> Hi! I'm not sure if KEY_PROG1/2/3 are good names here as we already use
>those for other actions (see bios_to_linux_keycode). Also there is:
I had missed this, do you have some recommendations on what would be
better codes to map this to?
I'll double check what the things that "were" mapping to KEY_PROG1 etc
actually were. This might be a case of an expected clash if the functions
aren't in current generations.
>
>/* Wifi Catcher */
> { KE_KEY, 0xe011, { KEY_PROG2 } },
>
It's worth mentioning that Wifi Catcher hasn't been used for any Dell laptops
for a handful generations. The rugged 2in1's are current generation that have
these programmable buttons and don't have wifi catcher.
So there should be no "real" clash here.
> But probably we do not have better names...
In this particular case, I was thinking PROG1/2/3 were really the best option
and would be most intuitive because the keys really are labels "P1" "P2" and
"P3".
Here's the front of the tablet:
http://shop-media.intel.com/api/v2/helperservice/getimage?url=http://images.icecat.biz/img/norm/high/30031725-706.jpg&height=550&width=550
>
> Another small cosmetic change: align WMI codes, so 0x157 and 0x850 are
> at some column (similar like are formatted other actions).
OK.
next prev parent reply other threads:[~2016-07-27 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 20:01 [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Mario Limonciello
2016-07-27 5:19 ` Darren Hart
2016-07-27 7:23 ` Pali Rohár
2016-07-27 15:55 ` Mario_Limonciello [this message]
2016-07-27 16:05 ` Pali Rohár
2016-07-27 16:38 ` Darren Hart
2016-07-27 19:03 ` Mario_Limonciello
2016-07-27 20:15 ` Pali Rohár
2016-07-27 22:43 ` Darren Hart
2016-07-27 23:07 ` Dmitry Torokhov
2016-07-28 15:52 ` Mario_Limonciello
2016-07-28 18:49 ` Dmitry Torokhov
2016-07-28 19:22 ` Pali Rohár
2016-08-01 22:41 ` Mario_Limonciello
2016-07-28 15:36 ` Mario_Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469634909478.10239@Dell.com \
--to=mario_limonciello@dell.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).