From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Mario Limonciello <mario_limonciello@dell.com>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s
Date: Wed, 27 Jul 2016 09:23:50 +0200 [thread overview]
Message-ID: <20160727072350.GF29844@pali> (raw)
In-Reply-To: <20160727051909.GC75806@f23x64.localdomain>
On Tuesday 26 July 2016 22:19:09 Darren Hart wrote:
> On Fri, Jul 22, 2016 at 03:01:24PM -0500, Mario Limonciello wrote:
> > The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
> > and a detachable magnetic keyboard/mouse.
> >
> > Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
>
> +Pali
>
> Pali, any concerns?
Hi! I'm not sure if KEY_PROG1/2/3 are good names here as we already use
those for other actions (see bios_to_linux_keycode). Also there is:
/* Wifi Catcher */
{ KE_KEY, 0xe011, { KEY_PROG2 } },
But probably we do not have better names...
Another small cosmetic change: align WMI codes, so 0x157 and 0x850 are
at some column (similar like are formatted other actions).
> > ---
> > drivers/platform/x86/dell-wmi.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> > index 15c6f11..6ba42d0 100644
> > --- a/drivers/platform/x86/dell-wmi.c
> > +++ b/drivers/platform/x86/dell-wmi.c
> > @@ -222,6 +222,16 @@ static const struct key_entry dell_wmi_extra_keymap[] __initconst = {
> >
> > /* Stealth mode toggle */
> > { KE_IGNORE, 0x155, { KEY_RESERVED } },
> > +
> > + /* Rugged magnetic keyboard/mouse events */
> > + { KE_IGNORE, 0x156, { KEY_RESERVED } },
> > + { KE_IGNORE, 0x157, { KEY_RESERVED } },
> > +
> > + /* Rugged programmable (P1/P2/P3 keys) */
> > + { KE_KEY, 0x850, { KEY_PROG1 } },
> > + { KE_KEY, 0x851, { KEY_PROG2 } },
> > + { KE_KEY, 0x852, { KEY_PROG3 } },
> > +
> > };
> >
> > static struct input_dev *dell_wmi_input_dev;
> > --
> > 2.7.4
> >
> >
>
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-07-27 7:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 20:01 [PATCH] dell-wmi: Add events created by Dell Rugged 2-in-1s Mario Limonciello
2016-07-27 5:19 ` Darren Hart
2016-07-27 7:23 ` Pali Rohár [this message]
2016-07-27 15:55 ` Mario_Limonciello
2016-07-27 16:05 ` Pali Rohár
2016-07-27 16:38 ` Darren Hart
2016-07-27 19:03 ` Mario_Limonciello
2016-07-27 20:15 ` Pali Rohár
2016-07-27 22:43 ` Darren Hart
2016-07-27 23:07 ` Dmitry Torokhov
2016-07-28 15:52 ` Mario_Limonciello
2016-07-28 18:49 ` Dmitry Torokhov
2016-07-28 19:22 ` Pali Rohár
2016-08-01 22:41 ` Mario_Limonciello
2016-07-28 15:36 ` Mario_Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160727072350.GF29844@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).