From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input - elantech: fix debug dump of the current packet
Date: Thu, 28 Jul 2016 11:49:57 -0700 [thread overview]
Message-ID: <1469731797.3998.69.camel@perches.com> (raw)
In-Reply-To: <20160728184003.GE16852@dtor-ws>
On Thu, 2016-07-28 at 11:40 -0700, Dmitry Torokhov wrote:
> On Thu, Jul 28, 2016 at 11:30:56AM -0700, Joe Perches wrote:
> >
> > On Thu, 2016-07-28 at 11:58 +0200, Benjamin Tissoires wrote:
> > >
> > > The use of mixed psmouse_printk() and printk creates 2 lines in the log,
> > > while the use of %*ph solves everything.
> > >
> > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > > ---
> > > drivers/input/mouse/elantech.c | 8 ++------
> > > 1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> > > index 615d23e..3461d04 100644
> > > --- a/drivers/input/mouse/elantech.c
> > > +++ b/drivers/input/mouse/elantech.c
> > > @@ -222,12 +222,8 @@ static int elantech_write_reg(struct psmouse *psmouse, unsigned char reg,
> > > */
> > > static void elantech_packet_dump(struct psmouse *psmouse)
> > > {
> > > - int i;
> > > -
> > > - psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [");
> > > - for (i = 0; i < psmouse->pktsize; i++)
> > > - printk("%s0x%02x ", i ? ", " : " ", psmouse->packet[i]);
> > > - printk("]\n");
> > > + psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [%*ph]",
> > > + psmouse->pktsize, psmouse->packet);
> > > }
> > >
> > > /*
> > This should add a newline "\n" format termination but
> I added it, thanks for alerting me.
>
> >
> > how does the original produce multiple lines of output?
> >
> > It looks more like psmouse_printk should be removed altogether
> > and dev_debug should be used instead.
> That does not produce output by default whereas elantech driver uses
> elantech_packet_dump() to drop unexpected packets.
So use dev_printk(KERN_DEBUG, etc...
But I still don't see a mechanism for the original code to be
emitted on multiple lines.
How long is the longest packet?
This might truncate it.
Should this be ratelimited?
next prev parent reply other threads:[~2016-07-28 18:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 9:58 [PATCH] Input - elantech: fix debug dump of the current packet Benjamin Tissoires
2016-07-28 18:22 ` Dmitry Torokhov
2016-07-28 18:30 ` Joe Perches
2016-07-28 18:40 ` Dmitry Torokhov
2016-07-28 18:49 ` Joe Perches [this message]
2016-07-28 18:54 ` Dmitry Torokhov
2016-07-28 18:58 ` Joe Perches
2016-07-28 19:03 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469731797.3998.69.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).