From: Joe Perches <joe@perches.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input - elantech: fix debug dump of the current packet
Date: Thu, 28 Jul 2016 11:58:29 -0700 [thread overview]
Message-ID: <1469732309.3998.71.camel@perches.com> (raw)
In-Reply-To: <20160728185409.GG16852@dtor-ws>
On Thu, 2016-07-28 at 11:54 -0700, Dmitry Torokhov wrote:
> On Thu, Jul 28, 2016 at 11:49:57AM -0700, Joe Perches wrote:
[]
> > So use dev_printk(KERN_DEBUG, etc...
> #define psmouse_printk(level, psmouse, format, ...) \
> dev_printk(level, \
> &(psmouse)->ps2dev.serio->dev, \
> psmouse_fmt(format), ##__VA_ARGS__)
>
> I want to see current protocol module in th eoutput and I do not want to
> write "&(psmouse)->ps2dev.serio->dev" all the time.
There are only 2 uses of the macro.
$ git grep psmouse_printk
drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, psmouse, \
drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet [");
drivers/input/mouse/psmouse.h:#define psmouse_printk(level, psmouse, format, ...) \
next prev parent reply other threads:[~2016-07-28 18:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 9:58 [PATCH] Input - elantech: fix debug dump of the current packet Benjamin Tissoires
2016-07-28 18:22 ` Dmitry Torokhov
2016-07-28 18:30 ` Joe Perches
2016-07-28 18:40 ` Dmitry Torokhov
2016-07-28 18:49 ` Joe Perches
2016-07-28 18:54 ` Dmitry Torokhov
2016-07-28 18:58 ` Joe Perches [this message]
2016-07-28 19:03 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469732309.3998.71.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).