* [GIT PULL 0/1] perf/urgent fix
@ 2016-07-28 20:01 Arnaldo Carvalho de Melo
2016-07-28 20:01 ` [PATCH 1/1] tools lib api: Add str_error_c to libapi Arnaldo Carvalho de Melo
2016-07-29 14:54 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
0 siblings, 2 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-07-28 20:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
Arjan van de Ven, David Ahern, Jiri Olsa, Namhyung Kim,
Randy Dunlap, Wang Nan, Arnaldo Carvalho de Melo
Hi Ingo,
Please consider pulling,
- Arnaldo
The following changes since commit e4b3e0694bbc0350251e22abc215a7ff506f9162:
Merge tag 'perf-urgent-for-mingo-20160726' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-07-27 11:01:06 +0200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160728
for you to fetch changes up to 8149a774d53afeaf5eb337a813f828f8b8ce68da:
tools lib api: Add str_error_c to libapi (2016-07-27 17:16:43 -0300)
----------------------------------------------------------------
perf/urgent fix:
- Fix the tools/vm/ build by making libapi provide the str_error_c function,
that libapi uses but wasn't part of the list of objects linked with
tools/vm/ programs. (Arnaldo Carvalho de Melo)
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
----------------------------------------------------------------
Arnaldo Carvalho de Melo (1):
tools lib api: Add str_error_c to libapi
tools/lib/api/Build | 5 +++++
tools/perf/util/Build | 5 -----
tools/perf/util/python-ext-sources | 1 -
3 files changed, 5 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] tools lib api: Add str_error_c to libapi
2016-07-28 20:01 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo
@ 2016-07-28 20:01 ` Arnaldo Carvalho de Melo
2016-07-29 14:54 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-07-28 20:01 UTC (permalink / raw)
To: Ingo Molnar
Cc: linux-kernel, Arnaldo Carvalho de Melo, Adrian Hunter,
David Ahern, Jiri Olsa, Namhyung Kim, Wang Nan
From: Arnaldo Carvalho de Melo <acme@redhat.com>
Because it uses that function, which would lead every tool using it
to need to link against tools/lib/str_error_r.o.
This fixes building tools/vm/, that links with libapi.
Reported-by: Arjan van de Ven <arjan@linux.intel.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: b31e3e3316a7 ("tools lib api fs: Use str_error_r()")
Link: http://lkml.kernel.org/n/tip-aedt3qzibhnhaov2j4caqi61@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/api/Build | 5 +++++
tools/perf/util/Build | 5 -----
tools/perf/util/python-ext-sources | 1 -
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/tools/lib/api/Build b/tools/lib/api/Build
index 954c644f7ad9..6e2373db5598 100644
--- a/tools/lib/api/Build
+++ b/tools/lib/api/Build
@@ -2,3 +2,8 @@ libapi-y += fd/
libapi-y += fs/
libapi-y += cpu.o
libapi-y += debug.o
+libapi-y += str_error_r.o
+
+$(OUTPUT)str_error_r.o: ../str_error_r.c FORCE
+ $(call rule_mkdir)
+ $(call if_changed_dep,cc_o_c)
diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 2fa7d8b69873..91c5f6e1af59 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -70,7 +70,6 @@ libperf-y += stat.o
libperf-y += stat-shadow.o
libperf-y += record.o
libperf-y += srcline.o
-libperf-y += str_error_r.o
libperf-y += data.o
libperf-y += tsc.o
libperf-y += cloexec.o
@@ -176,10 +175,6 @@ $(OUTPUT)util/libstring.o: ../lib/string.c FORCE
$(call rule_mkdir)
$(call if_changed_dep,cc_o_c)
-$(OUTPUT)util/str_error_r.o: ../lib/str_error_r.c FORCE
- $(call rule_mkdir)
- $(call if_changed_dep,cc_o_c)
-
$(OUTPUT)util/hweight.o: ../lib/hweight.c FORCE
$(call rule_mkdir)
$(call if_changed_dep,cc_o_c)
diff --git a/tools/perf/util/python-ext-sources b/tools/perf/util/python-ext-sources
index 5065ec98049c..b7d4f4aeee61 100644
--- a/tools/perf/util/python-ext-sources
+++ b/tools/perf/util/python-ext-sources
@@ -13,7 +13,6 @@ util/cpumap.c
../lib/bitmap.c
../lib/find_bit.c
../lib/hweight.c
-../lib/str_error_r.c
../lib/vsprintf.c
util/thread_map.c
util/util.c
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [GIT PULL 0/1] perf/urgent fix
2016-07-28 20:01 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo
2016-07-28 20:01 ` [PATCH 1/1] tools lib api: Add str_error_c to libapi Arnaldo Carvalho de Melo
@ 2016-07-29 14:54 ` Ingo Molnar
1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2016-07-29 14:54 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: linux-kernel, Adrian Hunter, Arjan van de Ven, David Ahern,
Jiri Olsa, Namhyung Kim, Randy Dunlap, Wang Nan,
Arnaldo Carvalho de Melo
* Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Hi Ingo,
>
> Please consider pulling,
>
> - Arnaldo
>
> The following changes since commit e4b3e0694bbc0350251e22abc215a7ff506f9162:
>
> Merge tag 'perf-urgent-for-mingo-20160726' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-07-27 11:01:06 +0200)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-20160728
>
> for you to fetch changes up to 8149a774d53afeaf5eb337a813f828f8b8ce68da:
>
> tools lib api: Add str_error_c to libapi (2016-07-27 17:16:43 -0300)
>
> ----------------------------------------------------------------
> perf/urgent fix:
>
> - Fix the tools/vm/ build by making libapi provide the str_error_c function,
> that libapi uses but wasn't part of the list of objects linked with
> tools/vm/ programs. (Arnaldo Carvalho de Melo)
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> ----------------------------------------------------------------
> Arnaldo Carvalho de Melo (1):
> tools lib api: Add str_error_c to libapi
>
> tools/lib/api/Build | 5 +++++
> tools/perf/util/Build | 5 -----
> tools/perf/util/python-ext-sources | 1 -
> 3 files changed, 5 insertions(+), 6 deletions(-)
Pulled, thanks a lot Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-29 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-28 20:01 [GIT PULL 0/1] perf/urgent fix Arnaldo Carvalho de Melo
2016-07-28 20:01 ` [PATCH 1/1] tools lib api: Add str_error_c to libapi Arnaldo Carvalho de Melo
2016-07-29 14:54 ` [GIT PULL 0/1] perf/urgent fix Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).