From: Joe Perches <joe@perches.com>
To: Nadim almas <nadim.902@gmail.com>, labbott@redhat.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for
Date: Fri, 29 Jul 2016 14:14:23 -0700 [thread overview]
Message-ID: <1469826863.3998.91.camel@perches.com> (raw)
In-Reply-To: <1469826406-18142-1-git-send-email-nadim.902@gmail.com>
On Fri, 2016-07-29 at 14:06 -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file rtw_android.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
>
> It is done using script Coccinelle. And coccinelle uses following semantic
> patch for this compression function:
[]
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
[]
> @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle)
> {
> int ret;
>
> - ret = kref_put(&handle->ref, ion_handle_destroy);
> -
> - return ret;
> + return kref_put(&handle->ref, ion_handle_destroy);
> }
int ret; is now unused.
Please make sure you compile the files modified by any script
and remove any newly introduced warnings.
> static int ion_handle_put(struct ion_handle *handle)
> @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
> return -ENODEV;
> }
> mutex_unlock(&client->lock);
> - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
> - return ret;
> +
> + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
> }
> EXPORT_SYMBOL(ion_phys);
next prev parent reply other threads:[~2016-07-29 21:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 21:06 [PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for Nadim almas
2016-07-29 21:14 ` Joe Perches [this message]
2016-07-30 9:50 Nadim almas
2016-07-30 9:54 Nadim almas
2016-07-30 10:58 ` Joe Perches
2016-07-30 11:12 Nadim almas
2016-07-30 15:26 ` Markus Böhme
2016-07-30 16:11 Nadim almas
2016-07-31 6:23 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469826863.3998.91.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nadim.902@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).