From: "Markus Böhme" <markus.boehme@mailbox.org>
To: Nadim almas <nadim.902@gmail.com>, labbott@redhat.com
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for
Date: Sat, 30 Jul 2016 17:26:08 +0200 [thread overview]
Message-ID: <ef01df4d-4b8d-3dd3-3930-ec1f8bd15b34@mailbox.org> (raw)
In-Reply-To: <1469877168-7864-1-git-send-email-nadim.902@gmail.com>
On 07/30/2016 01:12 PM, Nadim almas wrote:
> This patch compresses two lines in to a single line in file rtw_android.c
> if immediate return statement is found. It also removes variable
> bytes_written as it is no longer needed.
This commit message is wrong. Neither are you editing rtw_android.c, nor
are you doing anything to a variable named bytes_written. Additionally,
the short description in your first line/subject seems to be missing a
word or two at the end.
>
> It is done using script Coccinelle. And coccinelle uses following semantic
> patch for this compression function:
>
>
> @@
> expression e, ret;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
> drivers/staging/android/ion/ion.c | 8 +++-----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 52345df..271395b 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle)
> {
> - int ret;
>
> - ret = kref_put(&handle->ref, ion_handle_destroy);
> -
> - return ret;
> + return kref_put(&handle->ref, ion_handle_destroy);
> }
>
> static int ion_handle_put(struct ion_handle *handle)
> @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle,
> return -ENODEV;
> }
> mutex_unlock(&client->lock);
> - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
> - return ret;
> + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len);
> }
> EXPORT_SYMBOL(ion_phys);
What Joe told you about compile-testing, warnings and unused variables
still applies.
next prev parent reply other threads:[~2016-07-30 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 11:12 [PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for Nadim almas
2016-07-30 15:26 ` Markus Böhme [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-30 16:11 Nadim almas
2016-07-31 6:23 ` Laura Abbott
2016-07-30 9:54 Nadim almas
2016-07-30 10:58 ` Joe Perches
2016-07-30 9:50 Nadim almas
2016-07-29 21:06 Nadim almas
2016-07-29 21:14 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef01df4d-4b8d-3dd3-3930-ec1f8bd15b34@mailbox.org \
--to=markus.boehme@mailbox.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nadim.902@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).