* [PATCH] fs: fix a bug when new_insert_key is not initialization
@ 2016-07-30 3:51 zhongjiang
2016-08-01 23:05 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: zhongjiang @ 2016-07-30 3:51 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel
From: zhong jiang <zhongjiang@huawei.com>
when compile the kenrel code, I happens to the following warn.
fs/reiserfs/ibalance.c:1156:2: warning: ‘new_insert_key’ may be used
uninitialized in this function.
memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
The patch fix it by check the new_insert_ptr. if new_insert_ptr is not
NULL, we ensure that new_insert_key is assigned. therefore, memcpy will
saftly exec the operatetion.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/reiserfs/ibalance.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/reiserfs/ibalance.c b/fs/reiserfs/ibalance.c
index b751eea..2c46829 100644
--- a/fs/reiserfs/ibalance.c
+++ b/fs/reiserfs/ibalance.c
@@ -1153,8 +1153,10 @@ int balance_internal(struct tree_balance *tb,
insert_ptr);
}
- memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
- insert_ptr[0] = new_insert_ptr;
+ if (new_insert_ptr) {
+ memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
+ insert_ptr[0] = new_insert_ptr;
+ }
return order;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: fix a bug when new_insert_key is not initialization
2016-07-30 3:51 [PATCH] fs: fix a bug when new_insert_key is not initialization zhongjiang
@ 2016-08-01 23:05 ` Andrew Morton
2016-08-02 2:26 ` zhong jiang
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2016-08-01 23:05 UTC (permalink / raw)
To: zhongjiang; +Cc: linux-mm, linux-kernel
On Sat, 30 Jul 2016 11:51:09 +0800 zhongjiang <zhongjiang@huawei.com> wrote:
> From: zhong jiang <zhongjiang@huawei.com>
>
> when compile the kenrel code, I happens to the following warn.
> fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used
> uninitialized in this function.
> memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
>
> The patch fix it by check the new_insert_ptr. if new_insert_ptr is not
> NULL, we ensure that new_insert_key is assigned. therefore, memcpy will
> saftly exec the operatetion.
>
> --- a/fs/reiserfs/ibalance.c
> +++ b/fs/reiserfs/ibalance.c
> @@ -1153,8 +1153,10 @@ int balance_internal(struct tree_balance *tb,
> insert_ptr);
> }
>
> - memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
> - insert_ptr[0] = new_insert_ptr;
> + if (new_insert_ptr) {
> + memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
> + insert_ptr[0] = new_insert_ptr;
> + }
>
> return order;
Jeff has aleady fixed this with an equivalent patch. It's in -mm at
present.
From: Jeff Mahoney <jeffm@suse.com>
Subject: reiserfs: fix "new_insert_key may be used uninitialized ..."
new_insert_key only makes any sense when it's associated with a
new_insert_ptr, which is initialized to NULL and changed to a buffer_head
when we also initialize new_insert_key. We can key off of that to avoid
the uninitialized warning.
Link: http://lkml.kernel.org/r/5eca5ffb-2155-8df2-b4a2-f162f105efed@suse.com
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Jan Kara <jack@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/reiserfs/ibalance.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/reiserfs/ibalance.c~reiserfs-fix-new_insert_key-may-be-used-uninitialized fs/reiserfs/ibalance.c
--- a/fs/reiserfs/ibalance.c~reiserfs-fix-new_insert_key-may-be-used-uninitialized
+++ a/fs/reiserfs/ibalance.c
@@ -1153,8 +1153,9 @@ int balance_internal(struct tree_balance
insert_ptr);
}
- memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
insert_ptr[0] = new_insert_ptr;
+ if (new_insert_ptr)
+ memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
return order;
}
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: fix a bug when new_insert_key is not initialization
2016-08-01 23:05 ` Andrew Morton
@ 2016-08-02 2:26 ` zhong jiang
0 siblings, 0 replies; 3+ messages in thread
From: zhong jiang @ 2016-08-02 2:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm, linux-kernel
On 2016/8/2 7:05, Andrew Morton wrote:
> On Sat, 30 Jul 2016 11:51:09 +0800 zhongjiang <zhongjiang@huawei.com> wrote:
>
>> From: zhong jiang <zhongjiang@huawei.com>
>>
>> when compile the kenrel code, I happens to the following warn.
>> fs/reiserfs/ibalance.c:1156:2: warning: ___new_insert_key___ may be used
>> uninitialized in this function.
>> memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
>>
>> The patch fix it by check the new_insert_ptr. if new_insert_ptr is not
>> NULL, we ensure that new_insert_key is assigned. therefore, memcpy will
>> saftly exec the operatetion.
>>
>> --- a/fs/reiserfs/ibalance.c
>> +++ b/fs/reiserfs/ibalance.c
>> @@ -1153,8 +1153,10 @@ int balance_internal(struct tree_balance *tb,
>> insert_ptr);
>> }
>>
>> - memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
>> - insert_ptr[0] = new_insert_ptr;
>> + if (new_insert_ptr) {
>> + memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
>> + insert_ptr[0] = new_insert_ptr;
>> + }
>>
>> return order;
> Jeff has aleady fixed this with an equivalent patch. It's in -mm at
> present.
>
> From: Jeff Mahoney <jeffm@suse.com>
> Subject: reiserfs: fix "new_insert_key may be used uninitialized ..."
>
> new_insert_key only makes any sense when it's associated with a
> new_insert_ptr, which is initialized to NULL and changed to a buffer_head
> when we also initialize new_insert_key. We can key off of that to avoid
> the uninitialized warning.
>
> Link: http://lkml.kernel.org/r/5eca5ffb-2155-8df2-b4a2-f162f105efed@suse.com
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> fs/reiserfs/ibalance.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN fs/reiserfs/ibalance.c~reiserfs-fix-new_insert_key-may-be-used-uninitialized fs/reiserfs/ibalance.c
> --- a/fs/reiserfs/ibalance.c~reiserfs-fix-new_insert_key-may-be-used-uninitialized
> +++ a/fs/reiserfs/ibalance.c
> @@ -1153,8 +1153,9 @@ int balance_internal(struct tree_balance
> insert_ptr);
> }
>
> - memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
> insert_ptr[0] = new_insert_ptr;
> + if (new_insert_ptr)
> + memcpy(new_insert_key_addr, &new_insert_key, KEY_SIZE);
>
> return order;
> }
> _
>
>
> .
>
ok , I did not notice. thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-02 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-30 3:51 [PATCH] fs: fix a bug when new_insert_key is not initialization zhongjiang
2016-08-01 23:05 ` Andrew Morton
2016-08-02 2:26 ` zhong jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).