[PATCH 1/1] Staging: comedi: cd_pcidas64.c: Compression of

[PATCH 1/1] Staging: comedi: cd_pcidas64.c: Compression of

[Nadim almas]

This patch compresses two lines in to a single line in file
cb_pcidas64.c
if immediate return statement is found.

It is done using script Coccinelle. And coccinelle uses following
semantic patch for this compression function:

@@
expression e, ret;
@@

-ret =
+return
     e;
-return ret

Signed-off-by: Nadim Almas <nadim.902@gmail.com>
---
 
 drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)


 
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c
index 1f9c08a..d30cf3d 100644
--- a/drivers/staging/comedi/drivers/cb_pcidas64.c
+++ b/drivers/staging/comedi/drivers/cb_pcidas64.c
@@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples)
 	if (retval < 0)
 		return retval;
 
-	num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio;
-
-	return num_samples;
+	return retval * fifo->num_segments * fifo->sample_packing_ratio;
 }
 
 /* query length of fifo */
-- 
2.7.4

Re: [PATCH 1/1] Staging: comedi: cd_pcidas64.c: Compression of

[Greg KH]

On Tue, Aug 02, 2016 at 11:16:04AM -0700, Nadim almas wrote:
> This patch compresses two lines in to a single line in file
> cb_pcidas64.c
> if immediate return statement is found.
> 
> It is done using script Coccinelle. And coccinelle uses following
> semantic patch for this compression function:
> 
> @@
> expression e, ret;
> @@
> 
> -ret =
> +return
>      e;
> -return ret
> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  
>  drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 

Subject is still quite odd :(