From: York Sun <york.sun@nxp.com>
To: <linux-edac@vger.kernel.org>
Cc: <morbidrsa@gmail.com>, <oss@buserror.net>, <stuart.yoder@nxp.com>,
<bp@alien8.de>, York Sun <york.sun@nxp.com>,
Doug Thompson <dougthompson@xmission.com>, <mchehab@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [Patch v3 09/11] driver/edac/fsl_ddr: Fix kernel warning when module is removed
Date: Thu, 4 Aug 2016 15:58:34 -0700 [thread overview]
Message-ID: <1470351518-22404-10-git-send-email-york.sun@nxp.com> (raw)
In-Reply-To: <1470351518-22404-1-git-send-email-york.sun@nxp.com>
When compiled as a module, removing this module causes kernel
warnings when irq_dispose_mapping() is called. Instead of calling
irq_of_parse_and_map(), using platform_get_irq() to acquire the
IRQ number.
Signed-off-by: York Sun <york.sun@nxp.com>
---
Change log
v3: no change
v2: no change
drivers/edac/fsl_ddr_edac.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
index b1b7924..a3fc8fe 100644
--- a/drivers/edac/fsl_ddr_edac.c
+++ b/drivers/edac/fsl_ddr_edac.c
@@ -563,7 +563,7 @@ int fsl_ddr_mc_err_probe(struct platform_device *op)
ddr_out32(pdata->mc_vbase + MC_ERR_SBE, 0x10000);
/* register interrupts */
- pdata->irq = irq_of_parse_and_map(op->dev.of_node, 0);
+ pdata->irq = platform_get_irq(op, 0);
res = devm_request_irq(&op->dev, pdata->irq,
fsl_ddr_mc_isr,
IRQF_SHARED,
@@ -571,7 +571,6 @@ int fsl_ddr_mc_err_probe(struct platform_device *op)
if (res < 0) {
pr_err("%s: Unable to request irq %d for FSL DDR DRAM ERR\n",
__func__, pdata->irq);
- irq_dispose_mapping(pdata->irq);
res = -ENODEV;
goto err2;
}
@@ -603,7 +602,6 @@ int fsl_ddr_mc_err_remove(struct platform_device *op)
edac_dbg(0, "\n");
if (edac_op_state == EDAC_OPSTATE_INT) {
- irq_dispose_mapping(pdata->irq);
ddr_out32(pdata->mc_vbase + MC_ERR_INT_EN, 0);
}
--
2.7.4
next prev parent reply other threads:[~2016-08-04 23:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1470351518-22404-1-git-send-email-york.sun@nxp.com>
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
2016-08-04 23:36 ` Andrew Donnellan
2016-08-04 23:39 ` york sun
2016-08-05 6:58 ` Borislav Petkov
2016-08-05 3:43 ` Michael Ellerman
2016-08-05 4:26 ` york sun
2016-08-05 7:01 ` Borislav Petkov
2016-08-05 7:14 ` Johannes Thumshirn
2016-08-08 15:47 ` york sun
2016-08-05 20:29 ` york sun
2016-08-05 21:09 ` Scott Wood
2016-08-05 21:20 ` york sun
2016-08-05 21:57 ` Scott Wood
2016-08-04 22:58 ` [Patch v3 02/11] arch/microblaze/pci: Drop early_find_capability() York Sun
2016-08-04 22:58 ` [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 York Sun
2016-08-08 7:11 ` Borislav Petkov
2016-08-08 15:39 ` york sun
2016-08-09 3:32 ` Borislav Petkov
2016-08-09 4:31 ` york sun
2016-08-09 5:01 ` Borislav Petkov
2016-08-09 5:06 ` york sun
2016-08-09 6:56 ` Borislav Petkov
2016-08-09 15:57 ` york sun
[not found] ` <275db5cd-09cd-d971-0e43-3b4af060f0e8@nxp.com>
2016-08-09 16:40 ` york sun
2016-08-09 16:58 ` Borislav Petkov
2016-08-04 22:58 ` [Patch v3 04/11] driver/edac/mpc85xx_edac: Replace printk with proper pr_* format York Sun
2016-08-04 22:58 ` [Patch v3 05/11] driver/edac/fsl-ddr: Separate FSL DDR EDAC driver from MPC85xx York Sun
2016-08-08 7:36 ` Borislav Petkov
2016-08-08 15:32 ` york sun
2016-08-04 22:58 ` [Patch v3 06/11] driver/edac/fsl_ddr: Rename macros and names York Sun
2016-08-08 7:41 ` Borislav Petkov
2016-08-08 15:31 ` york sun
2016-08-04 22:58 ` [Patch v3 07/11] driver/edac/fsl_ddr: Add DDR4 type York Sun
2016-08-08 8:30 ` Borislav Petkov
2016-08-08 15:30 ` york sun
2016-08-04 22:58 ` [Patch v3 08/11] driver/edac/fsl_ddr: Add support of little endian York Sun
2016-08-08 8:50 ` Borislav Petkov
2016-08-08 15:26 ` york sun
2016-08-08 15:39 ` Mark Rutland
2016-08-04 22:58 ` York Sun [this message]
2016-08-04 22:58 ` [Patch v3 10/11] driver/edac/layerscape_edac: Add Layerscape EDAC support York Sun
2016-08-08 8:57 ` Alexander Stein
2016-08-08 15:16 ` york sun
2016-08-08 18:06 ` Marc Zyngier
2016-08-08 19:56 ` york sun
2016-08-09 11:12 ` Will Deacon
2016-08-09 15:27 ` york sun
2016-08-04 22:58 ` [Patch v3 11/11] arm64: Update device tree for Layerscape SoCs York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470351518-22404-10-git-send-email-york.sun@nxp.com \
--to=york.sun@nxp.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=morbidrsa@gmail.com \
--cc=oss@buserror.net \
--cc=stuart.yoder@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).