From: Borislav Petkov <bp@alien8.de>
To: York Sun <york.sun@nxp.com>
Cc: linux-edac@vger.kernel.org, morbidrsa@gmail.com,
oss@buserror.net, stuart.yoder@nxp.com,
Doug Thompson <dougthompson@xmission.com>,
mchehab@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Patch v3 07/11] driver/edac/fsl_ddr: Add DDR4 type
Date: Mon, 8 Aug 2016 10:30:54 +0200 [thread overview]
Message-ID: <20160808083054.GE20800@nazgul.tnic> (raw)
In-Reply-To: <1470351518-22404-8-git-send-email-york.sun@nxp.com>
On Thu, Aug 04, 2016 at 03:58:32PM -0700, York Sun wrote:
<--- Missing commit message.
> Signed-off-by: York Sun <york.sun@nxp.com>
>
> ---
> Change log
> v3: no change
> v2: no change
>
> drivers/edac/fsl_ddr_edac.c | 12 ++++++++++--
> drivers/edac/fsl_ddr_edac.h | 1 +
> 2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/fsl_ddr_edac.c b/drivers/edac/fsl_ddr_edac.c
> index 60761c0..88ecf7d 100644
> --- a/drivers/edac/fsl_ddr_edac.c
> +++ b/drivers/edac/fsl_ddr_edac.c
> @@ -376,6 +376,9 @@ static void fsl_ddr_init_csrows(struct mem_ctl_info *mci)
> case DSC_SDTYPE_DDR3:
Btw, those DSC_SDTYPE_* defines are used only here to map to the MEM_*
ones. You can just as well use the naked numbers here and drop the
DSC_SDTYPE* ones as it is clear what the naked numbers mean based on how
they're being used.
> mtype = MEM_RDDR3;
> break;
> + case DSC_SDTYPE_DDR4:
> + mtype = MEM_RDDR4;
> + break;
> default:
> mtype = MEM_UNKNOWN;
> break;
> @@ -391,6 +394,9 @@ static void fsl_ddr_init_csrows(struct mem_ctl_info *mci)
> case DSC_SDTYPE_DDR3:
> mtype = MEM_DDR3;
> break;
> + case DSC_SDTYPE_DDR4:
> + mtype = MEM_DDR4;
> + break;
> default:
> mtype = MEM_UNKNOWN;
> break;
> @@ -495,8 +501,10 @@ int fsl_ddr_mc_err_probe(struct platform_device *op)
> }
>
> edac_dbg(3, "init mci\n");
> - mci->mtype_cap = MEM_FLAG_RDDR | MEM_FLAG_RDDR2 |
> - MEM_FLAG_DDR | MEM_FLAG_DDR2;
> + mci->mtype_cap = MEM_FLAG_DDR | MEM_FLAG_RDDR |
> + MEM_FLAG_DDR2 | MEM_FLAG_RDDR2 |
> + MEM_FLAG_DDR3 | MEM_FLAG_RDDR3 |
DDR3 is silently added too, you can talk about that in the commit
message, for example.
> + MEM_FLAG_DDR4 | MEM_FLAG_RDDR4;
> mci->edac_ctl_cap = EDAC_FLAG_NONE | EDAC_FLAG_SECDED;
> mci->edac_cap = EDAC_FLAG_SECDED;
> mci->mod_name = EDAC_MOD_STR;
> diff --git a/drivers/edac/fsl_ddr_edac.h b/drivers/edac/fsl_ddr_edac.h
> index 556bac5..c7b7dbf 100644
> --- a/drivers/edac/fsl_ddr_edac.h
> +++ b/drivers/edac/fsl_ddr_edac.h
> @@ -50,6 +50,7 @@
> #define DSC_SDTYPE_DDR 0x02000000
> #define DSC_SDTYPE_DDR2 0x03000000
> #define DSC_SDTYPE_DDR3 0x07000000
> +#define DSC_SDTYPE_DDR4 0x05000000
> #define DSC_X32_EN 0x00000020
>
> /* Err_Int_En */
> --
> 2.7.4
>
>
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2016-08-08 8:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1470351518-22404-1-git-send-email-york.sun@nxp.com>
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
2016-08-04 23:36 ` Andrew Donnellan
2016-08-04 23:39 ` york sun
2016-08-05 6:58 ` Borislav Petkov
2016-08-05 3:43 ` Michael Ellerman
2016-08-05 4:26 ` york sun
2016-08-05 7:01 ` Borislav Petkov
2016-08-05 7:14 ` Johannes Thumshirn
2016-08-08 15:47 ` york sun
2016-08-05 20:29 ` york sun
2016-08-05 21:09 ` Scott Wood
2016-08-05 21:20 ` york sun
2016-08-05 21:57 ` Scott Wood
2016-08-04 22:58 ` [Patch v3 02/11] arch/microblaze/pci: Drop early_find_capability() York Sun
2016-08-04 22:58 ` [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 York Sun
2016-08-08 7:11 ` Borislav Petkov
2016-08-08 15:39 ` york sun
2016-08-09 3:32 ` Borislav Petkov
2016-08-09 4:31 ` york sun
2016-08-09 5:01 ` Borislav Petkov
2016-08-09 5:06 ` york sun
2016-08-09 6:56 ` Borislav Petkov
2016-08-09 15:57 ` york sun
[not found] ` <275db5cd-09cd-d971-0e43-3b4af060f0e8@nxp.com>
2016-08-09 16:40 ` york sun
2016-08-09 16:58 ` Borislav Petkov
2016-08-04 22:58 ` [Patch v3 04/11] driver/edac/mpc85xx_edac: Replace printk with proper pr_* format York Sun
2016-08-04 22:58 ` [Patch v3 05/11] driver/edac/fsl-ddr: Separate FSL DDR EDAC driver from MPC85xx York Sun
2016-08-08 7:36 ` Borislav Petkov
2016-08-08 15:32 ` york sun
2016-08-04 22:58 ` [Patch v3 06/11] driver/edac/fsl_ddr: Rename macros and names York Sun
2016-08-08 7:41 ` Borislav Petkov
2016-08-08 15:31 ` york sun
2016-08-04 22:58 ` [Patch v3 07/11] driver/edac/fsl_ddr: Add DDR4 type York Sun
2016-08-08 8:30 ` Borislav Petkov [this message]
2016-08-08 15:30 ` york sun
2016-08-04 22:58 ` [Patch v3 08/11] driver/edac/fsl_ddr: Add support of little endian York Sun
2016-08-08 8:50 ` Borislav Petkov
2016-08-08 15:26 ` york sun
2016-08-08 15:39 ` Mark Rutland
2016-08-04 22:58 ` [Patch v3 09/11] driver/edac/fsl_ddr: Fix kernel warning when module is removed York Sun
2016-08-04 22:58 ` [Patch v3 10/11] driver/edac/layerscape_edac: Add Layerscape EDAC support York Sun
2016-08-08 8:57 ` Alexander Stein
2016-08-08 15:16 ` york sun
2016-08-08 18:06 ` Marc Zyngier
2016-08-08 19:56 ` york sun
2016-08-09 11:12 ` Will Deacon
2016-08-09 15:27 ` york sun
2016-08-04 22:58 ` [Patch v3 11/11] arm64: Update device tree for Layerscape SoCs York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808083054.GE20800@nazgul.tnic \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=morbidrsa@gmail.com \
--cc=oss@buserror.net \
--cc=stuart.yoder@nxp.com \
--cc=york.sun@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).