[PATCH 0/2] STi: Add ports-implemented property support

[PATCH 0/2] STi: Add ports-implemented property support

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@st.com>

Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
returns 0. So force HOST_PORTS_IMPL to 1 by using
ports-implemented DT property.
Update achci_st driver and STi dts accordingly

Patrice Chotard (2):
  ahci: st: Add ports-implemented property in support
  ARM: dts: STiH407-family: Add ports-implemented property in sata nodes

 arch/arm/boot/dts/stih407-family.dtsi | 4 ++++
 drivers/ata/ahci_st.c                 | 4 ++++
 2 files changed, 8 insertions(+)

-- 
1.9.1

[PATCH 1/2] ahci: st: Add ports-implemented property in support

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@st.com>

Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
returns 0. So force_port_map to 1 by using ports-implemented
DT property.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
 drivers/ata/ahci_st.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
index 8ff428f..bc345f2 100644
--- a/drivers/ata/ahci_st.c
+++ b/drivers/ata/ahci_st.c
@@ -147,6 +147,7 @@ static struct scsi_host_template ahci_platform_sht = {
 
 static int st_ahci_probe(struct platform_device *pdev)
 {
+	struct device *dev = &pdev->dev;
 	struct st_ahci_drv_data *drv_data;
 	struct ahci_host_priv *hpriv;
 	int err;
@@ -170,6 +171,9 @@ static int st_ahci_probe(struct platform_device *pdev)
 
 	st_ahci_configure_oob(hpriv->mmio);
 
+	of_property_read_u32(dev->of_node,
+			     "ports-implemented", &hpriv->force_port_map);
+
 	err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info,
 				      &ahci_platform_sht);
 	if (err) {
-- 
1.9.1

[PATCH 2/2] ARM: dts: STiH407-family: Add ports-implemented property in sata nodes

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@st.com>

Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
returns 0. So force HOST_PORTS_IMPL to 1 by using
ports-implemented DT property.

Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
---
 arch/arm/boot/dts/stih407-family.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
index d294e82..36d40f0 100644
--- a/arch/arm/boot/dts/stih407-family.dtsi
+++ b/arch/arm/boot/dts/stih407-family.dtsi
@@ -608,6 +608,8 @@
 			clock-names = "ahci_clk";
 			clocks = <&clk_s_c0_flexgen CLK_ICN_REG>;
 
+			ports-implemented = <0x1>;
+
 			status = "disabled";
 		};
 
@@ -631,6 +633,8 @@
 			clock-names = "ahci_clk";
 			clocks = <&clk_s_c0_flexgen CLK_ICN_REG>;
 
+			ports-implemented = <0x1>;
+
 			status = "disabled";
 		};
 
-- 
1.9.1

Re: [PATCH 0/2] STi: Add ports-implemented property support

[Tejun Heo]

On Wed, Aug 10, 2016 at 05:37:28PM +0200, patrice.chotard@st.com wrote:
> From: Patrice Chotard <patrice.chotard@st.com>
> 
> Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
> returns 0. So force HOST_PORTS_IMPL to 1 by using
> ports-implemented DT property.
> Update achci_st driver and STi dts accordingly

Applied to libata/for-4.9.

Thanks.

-- 
tejun

Re: [PATCH 1/2] ahci: st: Add ports-implemented property in support

[Sergei Shtylyov]

On 8/10/2016 6:37 PM, patrice.chotard@st.com wrote:

> From: Patrice Chotard <patrice.chotard@st.com>
>
> Despite ST AHCI version = 1.3, reading HOST_PORTS_IMPL
> returns 0. So force_port_map to 1 by using ports-implemented
> DT property.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
> ---
>  drivers/ata/ahci_st.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
> index 8ff428f..bc345f2 100644
> --- a/drivers/ata/ahci_st.c
> +++ b/drivers/ata/ahci_st.c
> @@ -147,6 +147,7 @@ static struct scsi_host_template ahci_platform_sht = {
>
>  static int st_ahci_probe(struct platform_device *pdev)
>  {
> +	struct device *dev = &pdev->dev;

    Why? You could just use 'pdev'.

>  	struct st_ahci_drv_data *drv_data;
>  	struct ahci_host_priv *hpriv;
>  	int err;
> @@ -170,6 +171,9 @@ static int st_ahci_probe(struct platform_device *pdev)
>
>  	st_ahci_configure_oob(hpriv->mmio);
>
> +	of_property_read_u32(dev->of_node,

    pdev->dev.of_node

> +			     "ports-implemented", &hpriv->force_port_map);
> +
>  	err = ahci_platform_init_host(pdev, hpriv, &st_ahci_port_info,
>  				      &ahci_platform_sht);
>  	if (err) {

MBR, Sergei