* [PATCH] add COMMON_CLK dependency for rockchip-inno-usb2
@ 2016-08-16 6:01 Frank Wang
2016-08-16 6:02 ` [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency Frank Wang
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wang @ 2016-08-16 6:01 UTC (permalink / raw)
To: heiko, kishon, linux, dianders, jwerner, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak
Cc: linux-kernel, devicetree, linux-usb, linux-rockchip, xzy.xu,
kever.yang, huangtao, william.wu, daniel.meng, frank.wang
On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2 driver
fails to build, and this adds the required Kconfig dependency to fix it.
Frank Wang (1):
phy: rockchip-inno-usb2: add COMMON_CLK dependency
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency
2016-08-16 6:01 [PATCH] add COMMON_CLK dependency for rockchip-inno-usb2 Frank Wang
@ 2016-08-16 6:02 ` Frank Wang
2016-08-16 16:31 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Frank Wang @ 2016-08-16 6:02 UTC (permalink / raw)
To: heiko, kishon, linux, dianders, jwerner, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak
Cc: linux-kernel, devicetree, linux-usb, linux-rockchip, xzy.xu,
kever.yang, huangtao, william.wu, daniel.meng, frank.wang
On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2
driver fails to build:
drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw'
has incomplete type
struct clk_hw clk480m_hw;
In file included from include/linux/clk.h:16:0
from drivers/phy/phy-rockchip-inno-usb2.c:17:
include/linux/kernel.h:831:48: error: initialization from incompatible
pointer type [-Werror=incompatible-pointer-types]
const typeof( ((type *)0)->member ) *__mptr = (ptr); \
... ...
Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
drivers/phy/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index f9bf981..c6d57e5 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB
config PHY_ROCKCHIP_INNO_USB2
tristate "Rockchip INNO USB2PHY Driver"
depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
+ depends on COMMON_CLK
select GENERIC_PHY
help
Support for Rockchip USB2.0 PHY with Innosilicon IP block.
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency
2016-08-16 6:02 ` [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency Frank Wang
@ 2016-08-16 16:31 ` Guenter Roeck
2016-08-17 10:19 ` Heiko Stübner
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2016-08-16 16:31 UTC (permalink / raw)
To: Frank Wang
Cc: heiko, kishon, dianders, jwerner, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-kernel, devicetree,
linux-usb, linux-rockchip, xzy.xu, kever.yang, huangtao,
william.wu, daniel.meng
On Tue, Aug 16, 2016 at 02:02:00PM +0800, Frank Wang wrote:
> On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2
> driver fails to build:
>
> drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw'
> has incomplete type
> struct clk_hw clk480m_hw;
>
> In file included from include/linux/clk.h:16:0
> from drivers/phy/phy-rockchip-inno-usb2.c:17:
> include/linux/kernel.h:831:48: error: initialization from incompatible
> pointer type [-Werror=incompatible-pointer-types]
> const typeof( ((type *)0)->member ) *__mptr = (ptr); \
>
> ... ...
>
> Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> ---
> drivers/phy/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index f9bf981..c6d57e5 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB
> config PHY_ROCKCHIP_INNO_USB2
> tristate "Rockchip INNO USB2PHY Driver"
> depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
> + depends on COMMON_CLK
Wonder what is preferred here. I find 33 "select COMMON_CLK" and
18 "depends on COMMON_CLK".
Either case
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> select GENERIC_PHY
> help
> Support for Rockchip USB2.0 PHY with Innosilicon IP block.
> --
> 1.7.9.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency
2016-08-16 16:31 ` Guenter Roeck
@ 2016-08-17 10:19 ` Heiko Stübner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2016-08-17 10:19 UTC (permalink / raw)
To: Guenter Roeck
Cc: Frank Wang, kishon, dianders, jwerner, robh+dt, pawel.moll,
mark.rutland, ijc+devicetree, galak, linux-kernel, devicetree,
linux-usb, linux-rockchip, xzy.xu, kever.yang, huangtao,
william.wu, daniel.meng
Am Dienstag, 16. August 2016, 09:31:50 schrieb Guenter Roeck:
> On Tue, Aug 16, 2016 at 02:02:00PM +0800, Frank Wang wrote:
> > On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2
> > driver fails to build:
> >
> > drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw'
> > has incomplete type
> >
> > struct clk_hw clk480m_hw;
> >
> > In file included from include/linux/clk.h:16:0
> >
> > from drivers/phy/phy-rockchip-inno-usb2.c:17:
> > include/linux/kernel.h:831:48: error: initialization from incompatible
> > pointer type [-Werror=incompatible-pointer-types]
> >
> > const typeof( ((type *)0)->member ) *__mptr = (ptr); \
> >
> > ... ...
> >
> > Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
> > ---
> >
> > drivers/phy/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index f9bf981..c6d57e5 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB
> >
> > config PHY_ROCKCHIP_INNO_USB2
> >
> > tristate "Rockchip INNO USB2PHY Driver"
> > depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
> >
> > + depends on COMMON_CLK
>
> Wonder what is preferred here. I find 33 "select COMMON_CLK" and
> 18 "depends on COMMON_CLK".
In drivers/ I count 12 select COMMON_CLK vs. 37 depends on COMMON_CLK
Do I need new glasses? :-)
With MMC_SDHCI_OF_ARASAN being the only one of all of them we're using on
Rockchip platforms.
I vaguely remember depends being preferred over select in general, so you
don't enable large parts by accident or cause some select chains - but I may
be wrong.
> Either case
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
for me as well:
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
> > select GENERIC_PHY
> > help
> >
> > Support for Rockchip USB2.0 PHY with Innosilicon IP block.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-17 10:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16 6:01 [PATCH] add COMMON_CLK dependency for rockchip-inno-usb2 Frank Wang
2016-08-16 6:02 ` [PATCH] phy: rockchip-inno-usb2: add COMMON_CLK dependency Frank Wang
2016-08-16 16:31 ` Guenter Roeck
2016-08-17 10:19 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).