linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RESEND PATCH 0/1] add COMMON_CLK dependency for rockchip-inno-usb2
@ 2016-08-16  6:13 Frank Wang
  2016-08-16  6:13 ` [RESEND PATCH 1/1] phy: rockchip-inno-usb2: add COMMON_CLK dependency Frank Wang
  0 siblings, 1 reply; 2+ messages in thread
From: Frank Wang @ 2016-08-16  6:13 UTC (permalink / raw)
  To: heiko, kishon, linux, dianders, jwerner, robh+dt, pawel.moll,
	mark.rutland, ijc+devicetree, galak
  Cc: linux-kernel, devicetree, linux-usb, linux-rockchip, xzy.xu,
	kever.yang, huangtao, william.wu, daniel.meng, frank.wang

On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2 driver
fails to build, and this adds the required Kconfig dependency to fix it.

Frank Wang (1):
  phy: rockchip-inno-usb2: add COMMON_CLK dependency

 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RESEND PATCH 1/1] phy: rockchip-inno-usb2: add COMMON_CLK dependency
  2016-08-16  6:13 [RESEND PATCH 0/1] add COMMON_CLK dependency for rockchip-inno-usb2 Frank Wang
@ 2016-08-16  6:13 ` Frank Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Wang @ 2016-08-16  6:13 UTC (permalink / raw)
  To: heiko, kishon, linux, dianders, jwerner, robh+dt, pawel.moll,
	mark.rutland, ijc+devicetree, galak
  Cc: linux-kernel, devicetree, linux-usb, linux-rockchip, xzy.xu,
	kever.yang, huangtao, william.wu, daniel.meng, frank.wang

On kernel builds without COMMON_CLK, the newly added rockchip-inno-usb2
driver fails to build:

drivers/phy/phy-rockchip-inno-usb2.c:124:16: error: field 'clk480m_hw'
has incomplete type
   struct clk_hw clk480m_hw;

In file included from include/linux/clk.h:16:0
                 from drivers/phy/phy-rockchip-inno-usb2.c:17:
include/linux/kernel.h:831:48: error: initialization from incompatible
pointer type [-Werror=incompatible-pointer-types]
   const typeof( ((type *)0)->member ) *__mptr = (ptr); \

  ... ...

Signed-off-by: Frank Wang <frank.wang@rock-chips.com>
---
 drivers/phy/Kconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index f9bf981..c6d57e5 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -370,6 +370,7 @@ config PHY_ROCKCHIP_USB
 config PHY_ROCKCHIP_INNO_USB2
 	tristate "Rockchip INNO USB2PHY Driver"
 	depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF
+	depends on COMMON_CLK
 	select GENERIC_PHY
 	help
 	  Support for Rockchip USB2.0 PHY with Innosilicon IP block.
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-16  6:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-16  6:13 [RESEND PATCH 0/1] add COMMON_CLK dependency for rockchip-inno-usb2 Frank Wang
2016-08-16  6:13 ` [RESEND PATCH 1/1] phy: rockchip-inno-usb2: add COMMON_CLK dependency Frank Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).