* [PATCH] atm: fore200e: Do not drop const qualifier
@ 2016-08-17 13:56 LABBE Corentin
2016-08-19 6:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: LABBE Corentin @ 2016-08-17 13:56 UTC (permalink / raw)
To: 3chas3; +Cc: linux-atm-general, linux-kernel, netdev, LABBE Corentin
The data member of structure firmware is const and this constness is
dropped by some cast.
This patch add some const for keeping the const information.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/atm/fore200e.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/fore200e.c b/drivers/atm/fore200e.c
index 75dde90..81aaa50 100644
--- a/drivers/atm/fore200e.c
+++ b/drivers/atm/fore200e.c
@@ -2489,7 +2489,7 @@ static int fore200e_load_and_start_fw(struct fore200e *fore200e)
{
const struct firmware *firmware;
struct device *device;
- struct fw_header *fw_header;
+ const struct fw_header *fw_header;
const __le32 *fw_data;
u32 fw_size;
u32 __iomem *load_addr;
@@ -2511,9 +2511,9 @@ static int fore200e_load_and_start_fw(struct fore200e *fore200e)
return err;
}
- fw_data = (__le32 *) firmware->data;
+ fw_data = (const __le32 *)firmware->data;
fw_size = firmware->size / sizeof(u32);
- fw_header = (struct fw_header *) firmware->data;
+ fw_header = (const struct fw_header *)firmware->data;
load_addr = fore200e->virt_base + le32_to_cpu(fw_header->load_offset);
DPRINTK(2, "device %s firmware being loaded at 0x%p (%d words)\n",
--
2.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] atm: fore200e: Do not drop const qualifier
2016-08-17 13:56 [PATCH] atm: fore200e: Do not drop const qualifier LABBE Corentin
@ 2016-08-19 6:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-08-19 6:50 UTC (permalink / raw)
To: clabbe.montjoie; +Cc: 3chas3, linux-atm-general, linux-kernel, netdev
From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: Wed, 17 Aug 2016 15:56:45 +0200
> The data member of structure firmware is const and this constness is
> dropped by some cast.
> This patch add some const for keeping the const information.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-19 6:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-17 13:56 [PATCH] atm: fore200e: Do not drop const qualifier LABBE Corentin
2016-08-19 6:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).