* [PATCH] thermal: armada: add support for suspend/resume @ 2016-07-21 10:43 Grzegorz Jaszczyk 2016-08-11 8:40 ` Grzegorz Jaszczyk 2016-08-19 13:06 ` Zhang Rui 0 siblings, 2 replies; 4+ messages in thread From: Grzegorz Jaszczyk @ 2016-07-21 10:43 UTC (permalink / raw) To: rui.zhang, edubezval, linux-pm, linux-kernel, thomas.petazzoni, gregory.clement Cc: mw, jaz, alior There is no need to implement subroutine for suspend since there is no data to store before suspending. Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com> --- drivers/thermal/armada_thermal.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c index ae75328..65f9838 100644 --- a/drivers/thermal/armada_thermal.c +++ b/drivers/thermal/armada_thermal.c @@ -304,12 +304,26 @@ static int armada_thermal_exit(struct platform_device *pdev) return 0; } +static int armada_thermal_resume(struct device *dev) +{ + struct thermal_zone_device *thermal = + dev_get_drvdata(dev); + struct armada_thermal_priv *priv = thermal->devdata; + + priv->data->init_sensor(to_platform_device(dev), priv); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(armada_thermal_pm_ops, NULL, armada_thermal_resume); + static struct platform_driver armada_thermal_driver = { .probe = armada_thermal_probe, .remove = armada_thermal_exit, .driver = { .name = "armada_thermal", .of_match_table = armada_thermal_id_table, + .pm = &armada_thermal_pm_ops, }, }; -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: armada: add support for suspend/resume 2016-07-21 10:43 [PATCH] thermal: armada: add support for suspend/resume Grzegorz Jaszczyk @ 2016-08-11 8:40 ` Grzegorz Jaszczyk 2016-08-19 13:06 ` Zhang Rui 1 sibling, 0 replies; 4+ messages in thread From: Grzegorz Jaszczyk @ 2016-08-11 8:40 UTC (permalink / raw) To: linux-pm, linux-kernel Cc: Marcin Wojtas, Grzegorz Jaszczyk, Lior Amsalem, Eduardo Valentin, rui.zhang, Thomas Petazzoni, Gregory CLEMENT Hi, I just wanted to kindly remind about this patch. Best regards, Grzegorz 2016-07-21 12:43 GMT+02:00 Grzegorz Jaszczyk <jaz@semihalf.com>: > There is no need to implement subroutine for suspend since there is no > data to store before suspending. > > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com> > --- > drivers/thermal/armada_thermal.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c > index ae75328..65f9838 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -304,12 +304,26 @@ static int armada_thermal_exit(struct platform_device *pdev) > return 0; > } > > +static int armada_thermal_resume(struct device *dev) > +{ > + struct thermal_zone_device *thermal = > + dev_get_drvdata(dev); > + struct armada_thermal_priv *priv = thermal->devdata; > + > + priv->data->init_sensor(to_platform_device(dev), priv); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(armada_thermal_pm_ops, NULL, armada_thermal_resume); > + > static struct platform_driver armada_thermal_driver = { > .probe = armada_thermal_probe, > .remove = armada_thermal_exit, > .driver = { > .name = "armada_thermal", > .of_match_table = armada_thermal_id_table, > + .pm = &armada_thermal_pm_ops, > }, > }; > > -- > 1.8.3.1 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: armada: add support for suspend/resume 2016-07-21 10:43 [PATCH] thermal: armada: add support for suspend/resume Grzegorz Jaszczyk 2016-08-11 8:40 ` Grzegorz Jaszczyk @ 2016-08-19 13:06 ` Zhang Rui 2016-09-06 0:36 ` Zhang Rui 1 sibling, 1 reply; 4+ messages in thread From: Zhang Rui @ 2016-08-19 13:06 UTC (permalink / raw) To: Grzegorz Jaszczyk, edubezval, linux-pm, linux-kernel, thomas.petazzoni, gregory.clement, ezequiel.garcia Cc: mw, alior On 四, 2016-07-21 at 12:43 +0200, Grzegorz Jaszczyk wrote: > There is no need to implement subroutine for suspend since there is > no > data to store before suspending. > > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com> Ezequiel, what do you think of this patch? thanks, rui > --- > drivers/thermal/armada_thermal.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/thermal/armada_thermal.c > b/drivers/thermal/armada_thermal.c > index ae75328..65f9838 100644 > --- a/drivers/thermal/armada_thermal.c > +++ b/drivers/thermal/armada_thermal.c > @@ -304,12 +304,26 @@ static int armada_thermal_exit(struct > platform_device *pdev) > return 0; > } > > +static int armada_thermal_resume(struct device *dev) > +{ > + struct thermal_zone_device *thermal = > + dev_get_drvdata(dev); > + struct armada_thermal_priv *priv = thermal->devdata; > + > + priv->data->init_sensor(to_platform_device(dev), priv); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(armada_thermal_pm_ops, NULL, > armada_thermal_resume); > + > static struct platform_driver armada_thermal_driver = { > .probe = armada_thermal_probe, > .remove = armada_thermal_exit, > .driver = { > .name = "armada_thermal", > .of_match_table = armada_thermal_id_table, > + .pm = &armada_thermal_pm_ops, > }, > }; > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] thermal: armada: add support for suspend/resume 2016-08-19 13:06 ` Zhang Rui @ 2016-09-06 0:36 ` Zhang Rui 0 siblings, 0 replies; 4+ messages in thread From: Zhang Rui @ 2016-09-06 0:36 UTC (permalink / raw) To: Grzegorz Jaszczyk, edubezval, linux-pm, linux-kernel, thomas.petazzoni, gregory.clement, ezequiel.garcia Cc: mw, alior On 五, 2016-08-19 at 21:06 +0800, Zhang Rui wrote: > On 四, 2016-07-21 at 12:43 +0200, Grzegorz Jaszczyk wrote: > > > > There is no need to implement subroutine for suspend since there is > > no > > data to store before suspending. > > > > Signed-off-by: Grzegorz Jaszczyk <jaz@semihalf.com> > Ezequiel, > > what do you think of this patch? > Ezequiel, As the author of the armada_thermal driver, it would be great if you can be the goalkeeper for all armada_thermal changes, and I'd prefer to get your ACK/NAK before applying/dropping any armada thermal patches. Can you please take a look at this patch? BTW, Grzegorz, for the PM callbacks, you'd better to either use __maybe_unused so that gcc can drop it if it's not used, or use #ifdef to compile them out when CONFIG_PM_SLEEP is not set. You can also refer to this patch https://patchwork.kernel.org/patch/931 1025/ thanks, rui > thanks, > rui > > > > --- > > drivers/thermal/armada_thermal.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/thermal/armada_thermal.c > > b/drivers/thermal/armada_thermal.c > > index ae75328..65f9838 100644 > > --- a/drivers/thermal/armada_thermal.c > > +++ b/drivers/thermal/armada_thermal.c > > @@ -304,12 +304,26 @@ static int armada_thermal_exit(struct > > platform_device *pdev) > > return 0; > > } > > > > +static int armada_thermal_resume(struct device *dev) > > +{ > > + struct thermal_zone_device *thermal = > > + dev_get_drvdata(dev); > > + struct armada_thermal_priv *priv = thermal->devdata; > > + > > + priv->data->init_sensor(to_platform_device(dev), priv); > > + > > + return 0; > > +} > > + > > +static SIMPLE_DEV_PM_OPS(armada_thermal_pm_ops, NULL, > > armada_thermal_resume); > > + > > static struct platform_driver armada_thermal_driver = { > > .probe = armada_thermal_probe, > > .remove = armada_thermal_exit, > > .driver = { > > .name = "armada_thermal", > > .of_match_table = armada_thermal_id_table, > > + .pm = &armada_thermal_pm_ops, > > }, > > }; > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-06 0:36 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-07-21 10:43 [PATCH] thermal: armada: add support for suspend/resume Grzegorz Jaszczyk 2016-08-11 8:40 ` Grzegorz Jaszczyk 2016-08-19 13:06 ` Zhang Rui 2016-09-06 0:36 ` Zhang Rui
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).