* [PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap()
@ 2016-08-26 14:25 Wei Yongjun
2016-08-27 12:16 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-26 14:25 UTC (permalink / raw)
To: Maxime Ripard, David Airlie, Chen-Yu Tsai
Cc: Wei Yongjun, dri-devel, linux-arm-kernel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
index 2145ecf..9180e7e 100644
--- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
+++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
@@ -374,10 +374,8 @@ static int sun4i_tcon_init_regmap(struct device *dev,
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
regs = devm_ioremap_resource(dev, res);
- if (IS_ERR(regs)) {
- dev_err(dev, "Couldn't map the TCON registers\n");
+ if (IS_ERR(regs))
return PTR_ERR(regs);
- }
tcon->regs = devm_regmap_init_mmio(dev, regs,
&sun4i_tcon_regmap_config);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap()
2016-08-26 14:25 [PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap() Wei Yongjun
@ 2016-08-27 12:16 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2016-08-27 12:16 UTC (permalink / raw)
To: Wei Yongjun
Cc: David Airlie, Chen-Yu Tsai, Wei Yongjun, dri-devel,
linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 436 bytes --]
On Fri, Aug 26, 2016 at 02:25:25PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-27 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-26 14:25 [PATCH -next] drm/sun4i: Remove redundant dev_err call in sun4i_tcon_init_regmap() Wei Yongjun
2016-08-27 12:16 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).