* [PATCH] RAS: debugfs: add missing header dependencies
@ 2016-08-31 9:13 Baoyou Xie
2016-08-31 10:01 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Baoyou Xie @ 2016-08-31 9:13 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, baoyou.xie, xie.baoyou
We get 3 warnings when building kernel with W=1:
drivers/ras/debugfs.c:8:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
drivers/ras/debugfs.c:38:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
drivers/ras/debugfs.c:54:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
In fact, these functions are declared in include/linux/ras.h,
so this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/ras/debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index 0322acf..627f6107 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -1,4 +1,5 @@
#include <linux/debugfs.h>
+#include <linux/ras.h>
static struct dentry *ras_debugfs_dir;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RAS: debugfs: add missing header dependencies
2016-08-31 9:13 [PATCH] RAS: debugfs: add missing header dependencies Baoyou Xie
@ 2016-08-31 10:01 ` Arnd Bergmann
0 siblings, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2016-08-31 10:01 UTC (permalink / raw)
To: Baoyou Xie; +Cc: linux-kernel, xie.baoyou
On Wednesday, August 31, 2016 5:13:26 PM CEST Baoyou Xie wrote:
> We get 3 warnings when building kernel with W=1:
> drivers/ras/debugfs.c:8:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
> drivers/ras/debugfs.c:38:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
> drivers/ras/debugfs.c:54:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
>
> In fact, these functions are declared in include/linux/ras.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] RAS, debugfs: add missing header dependencies
@ 2016-09-23 13:03 Baoyou Xie
0 siblings, 0 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-09-23 13:03 UTC (permalink / raw)
To: linux-kernel; +Cc: arnd, baoyou.xie, xie.baoyou
We get 3 warnings when building kernel with W=1:
drivers/ras/debugfs.c:7:5: warning: no previous prototype for 'ras_userspace_consumers' [-Wmissing-prototypes]
drivers/ras/debugfs.c:37:12: warning: no previous prototype for 'ras_add_daemon_trace' [-Wmissing-prototypes]
drivers/ras/debugfs.c:53:13: warning: no previous prototype for 'ras_debugfs_init' [-Wmissing-prototypes]
In fact, these functions are declared in linux/ras.h, so this patch
adds the missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/ras/debugfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ras/debugfs.c b/drivers/ras/debugfs.c
index 0322acf..627f6107 100644
--- a/drivers/ras/debugfs.c
+++ b/drivers/ras/debugfs.c
@@ -1,4 +1,5 @@
#include <linux/debugfs.h>
+#include <linux/ras.h>
static struct dentry *ras_debugfs_dir;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-23 13:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 9:13 [PATCH] RAS: debugfs: add missing header dependencies Baoyou Xie
2016-08-31 10:01 ` Arnd Bergmann
2016-09-23 13:03 [PATCH] RAS, " Baoyou Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).