From: Artem Savkov <asavkov@redhat.com>
To: paul.gortmaker@windriver.com
Cc: dhowells@redhat.com, james.l.morris@oracle.com,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Artem Savkov <asavkov@redhat.com>
Subject: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.
Date: Mon, 5 Sep 2016 14:37:59 +0200 [thread overview]
Message-ID: <1473079079-22465-1-git-send-email-asavkov@redhat.com> (raw)
Since BIG_KEYS can't be compiled as module it requires one of the "stdrng"
providers to be compiled into kernel. Otherwise big_key_crypto_init() fails
on crypto_alloc_rng step and next dereference of big_key_skcipher (e.g. in
big_key_preparse()) results in a NULL pointer dereference.
Signed-off-by: Artem Savkov <asavkov@redhat.com>
---
security/keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index f826e87..d942c7c 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -41,7 +41,7 @@ config BIG_KEYS
bool "Large payload keys"
depends on KEYS
depends on TMPFS
- select CRYPTO
+ depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y)
select CRYPTO_AES
select CRYPTO_ECB
select CRYPTO_RNG
--
2.7.4
next reply other threads:[~2016-09-05 12:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 12:37 Artem Savkov [this message]
2016-09-06 12:58 ` [PATCH] security/keys: make BIG_KEYS dependent on stdrng David Howells
2016-09-06 13:06 ` Artem Savkov
2016-09-06 13:11 ` David Howells
2016-09-06 13:16 ` Stephan Mueller
2016-09-06 13:25 ` Artem Savkov
2016-09-06 16:32 ` Kirill Marinushkin
2016-09-06 18:16 ` David Howells
2016-10-06 8:00 ` Artem Savkov
2016-10-24 14:50 ` David Howells
2016-10-25 10:26 ` Artem Savkov
2016-10-25 11:37 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473079079-22465-1-git-send-email-asavkov@redhat.com \
--to=asavkov@redhat.com \
--cc=dhowells@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).