From: David Howells <dhowells@redhat.com>
To: Artem Savkov <asavkov@redhat.com>,
Kirill Marinushkin <k.marinushkin@gmail.com>
Cc: dhowells@redhat.com, paul.gortmaker@windriver.com,
james.l.morris@oracle.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security/keys: make BIG_KEYS dependent on stdrng.
Date: Tue, 06 Sep 2016 14:11:56 +0100 [thread overview]
Message-ID: <32083.1473167516@warthog.procyon.org.uk> (raw)
In-Reply-To: <20160906130618.GA9055@shodan.usersys.redhat.com>
Artem Savkov <asavkov@redhat.com> wrote:
> > > - select CRYPTO
> > > + depends on (CRYPTO_ANSI_CPRNG = y || CRYPTO_DRBG = y)
> >
> > Should those be "==" not "="?
>
> Accodring to Documentation/kbuild/kconfig-language.txt (line 173) it is
> "=" and I can only see "=" being used in existing Kconfigs.
Okay. The other thing is that I have been given a conflicting patch (see
below). Is your fix preferable?
David
---
commit 69ed34b303f87a1a53470dd37149ac1573d79da2
Author: Kirill Marinushkin <k.marinushkin@gmail.com>
Date: Mon, 8 Aug 2016 23:19:32 +0200
KEYS: fix big_key dependency
Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
cc: David Howells <dhowells@redhat.com>
cc: Peter Hlavaty <zer0mem@yahoo.com>
cc: Greg KH <gregkh@linuxfoundation.org>
cc: stable@vger.kernel.org
---
security/keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index f826e87..8213221 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -44,7 +44,7 @@ config BIG_KEYS
select CRYPTO
select CRYPTO_AES
select CRYPTO_ECB
- select CRYPTO_RNG
+ select CRYPTO_ANSI_CPRNG
help
This option provides support for holding large keys within the kernel
(for example Kerberos ticket caches). The data may be stored out to
next prev parent reply other threads:[~2016-09-06 13:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 12:37 [PATCH] security/keys: make BIG_KEYS dependent on stdrng Artem Savkov
2016-09-06 12:58 ` David Howells
2016-09-06 13:06 ` Artem Savkov
2016-09-06 13:11 ` David Howells [this message]
2016-09-06 13:16 ` Stephan Mueller
2016-09-06 13:25 ` Artem Savkov
2016-09-06 16:32 ` Kirill Marinushkin
2016-09-06 18:16 ` David Howells
2016-10-06 8:00 ` Artem Savkov
2016-10-24 14:50 ` David Howells
2016-10-25 10:26 ` Artem Savkov
2016-10-25 11:37 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32083.1473167516@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=asavkov@redhat.com \
--cc=james.l.morris@oracle.com \
--cc=k.marinushkin@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).