* [PATCH] [media] coda: add missing header dependencies
@ 2016-09-06 7:50 Baoyou Xie
2016-09-06 9:21 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Baoyou Xie @ 2016-09-06 7:50 UTC (permalink / raw)
To: p.zabel, mchehab; +Cc: linux-media, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/media/platform/coda/coda-h264.c:22:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes]
In fact, this function is declared in coda.h, so this patch
add missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/media/platform/coda/coda-h264.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
index 456773a..09dfcca 100644
--- a/drivers/media/platform/coda/coda-h264.c
+++ b/drivers/media/platform/coda/coda-h264.c
@@ -13,6 +13,7 @@
#include <linux/kernel.h>
#include <linux/string.h>
+#include <coda.h>
static const u8 coda_filler_nal[14] = { 0x00, 0x00, 0x00, 0x01, 0x0c, 0xff,
0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x80 };
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] coda: add missing header dependencies
2016-09-06 7:50 [PATCH] [media] coda: add missing header dependencies Baoyou Xie
@ 2016-09-06 9:21 ` Arnd Bergmann
2016-09-06 9:28 ` Philipp Zabel
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2016-09-06 9:21 UTC (permalink / raw)
To: Baoyou Xie; +Cc: p.zabel, mchehab, linux-media, linux-kernel, xie.baoyou
On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
> #include <linux/kernel.h>
> #include <linux/string.h>
> +#include <coda.h>
>
by convention, we tend to write this as
#include "coda.h"
otherwise the patch looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] coda: add missing header dependencies
2016-09-06 9:21 ` Arnd Bergmann
@ 2016-09-06 9:28 ` Philipp Zabel
0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2016-09-06 9:28 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Baoyou Xie, mchehab, linux-media, linux-kernel, xie.baoyou
Am Dienstag, den 06.09.2016, 11:21 +0200 schrieb Arnd Bergmann:
> On Tuesday, September 6, 2016 3:50:56 PM CEST Baoyou Xie wrote:
> > #include <linux/kernel.h>
> > #include <linux/string.h>
> > +#include <coda.h>
> >
>
> by convention, we tend to write this as
>
> #include "coda.h"
>
> otherwise the patch looks good to me,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Same here, make that
+
+#include "coda.h"
and feel free to add
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
thanks
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] [media] coda: add missing header dependencies
@ 2016-09-24 5:29 Baoyou Xie
0 siblings, 0 replies; 4+ messages in thread
From: Baoyou Xie @ 2016-09-24 5:29 UTC (permalink / raw)
To: p.zabel, mchehab; +Cc: linux-media, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/media/platform/coda/coda-h264.c:21:5: warning: no previous prototype for 'coda_h264_padding' [-Wmissing-prototypes]
In fact, this function is declared in drivers/media/platform/coda/coda.h,
so this patch adds missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/media/platform/coda/coda-h264.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/coda/coda-h264.c b/drivers/media/platform/coda/coda-h264.c
index 456773a..6d6f555 100644
--- a/drivers/media/platform/coda/coda-h264.c
+++ b/drivers/media/platform/coda/coda-h264.c
@@ -13,6 +13,7 @@
#include <linux/kernel.h>
#include <linux/string.h>
+#include "coda.h"
static const u8 coda_filler_nal[14] = { 0x00, 0x00, 0x00, 0x01, 0x0c, 0xff,
0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0x80 };
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-24 5:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 7:50 [PATCH] [media] coda: add missing header dependencies Baoyou Xie
2016-09-06 9:21 ` Arnd Bergmann
2016-09-06 9:28 ` Philipp Zabel
2016-09-24 5:29 Baoyou Xie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).