* [PATCH] staging/lustre/obdclass: add missing header dependencies
@ 2016-09-08 8:46 Baoyou Xie
2016-09-08 17:51 ` James Simmons
2016-09-26 18:25 ` [lustre-devel] " James Simmons
0 siblings, 2 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-09-08 8:46 UTC (permalink / raw)
To: oleg.drokin, andreas.dilger, gregkh, mhocko, james.a.nunez,
uja.ornl, arnd, kirill.shutemov
Cc: lustre-devel, devel, linux-kernel, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
In fact, this function is declared in ../../include/obd_class.h,
so this patch add missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
index 8f70dd2..2daa834 100644
--- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
+++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
@@ -45,6 +45,7 @@
#include "../../include/obd_support.h"
#include "../../include/lprocfs_status.h"
+#include "../../include/obd_class.h"
struct static_lustre_uintvalue_attr {
struct {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging/lustre/obdclass: add missing header dependencies
2016-09-08 8:46 [PATCH] staging/lustre/obdclass: add missing header dependencies Baoyou Xie
@ 2016-09-08 17:51 ` James Simmons
2016-09-26 18:25 ` [lustre-devel] " James Simmons
1 sibling, 0 replies; 3+ messages in thread
From: James Simmons @ 2016-09-08 17:51 UTC (permalink / raw)
To: Baoyou Xie
Cc: oleg.drokin, andreas.dilger, gregkh, mhocko, james.a.nunez,
uja.ornl, arnd, kirill.shutemov, devel, linux-kernel, xie.baoyou,
lustre-devel
> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in ../../include/obd_class.h,
> so this patch add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Acked-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> index 8f70dd2..2daa834 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> @@ -45,6 +45,7 @@
>
> #include "../../include/obd_support.h"
> #include "../../include/lprocfs_status.h"
> +#include "../../include/obd_class.h"
>
> struct static_lustre_uintvalue_attr {
> struct {
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lustre-devel] [PATCH] staging/lustre/obdclass: add missing header dependencies
2016-09-08 8:46 [PATCH] staging/lustre/obdclass: add missing header dependencies Baoyou Xie
2016-09-08 17:51 ` James Simmons
@ 2016-09-26 18:25 ` James Simmons
1 sibling, 0 replies; 3+ messages in thread
From: James Simmons @ 2016-09-26 18:25 UTC (permalink / raw)
To: Baoyou Xie
Cc: oleg.drokin, andreas.dilger, gregkh, mhocko, james.a.nunez,
uja.ornl, arnd, kirill.shutemov, devel, linux-kernel, xie.baoyou,
lustre-devel
> We get 1 warning when building kernel with W=1:
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:157:5: warning: no previous prototype for 'obd_sysctl_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in ../../include/obd_class.h,
> so this patch add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Reviewed-by: James Simmons <jsimmons@infradead.org>
> ---
> drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> index 8f70dd2..2daa834 100644
> --- a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> +++ b/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
> @@ -45,6 +45,7 @@
>
> #include "../../include/obd_support.h"
> #include "../../include/lprocfs_status.h"
> +#include "../../include/obd_class.h"
>
> struct static_lustre_uintvalue_attr {
> struct {
> --
> 2.7.4
>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-26 18:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 8:46 [PATCH] staging/lustre/obdclass: add missing header dependencies Baoyou Xie
2016-09-08 17:51 ` James Simmons
2016-09-26 18:25 ` [lustre-devel] " James Simmons
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).