From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Vignesh R <vigneshr@ti.com>, Yong Li <yong.b.li@intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v5 4/6] gpio: pca953x: remove an unused variable
Date: Thu, 8 Sep 2016 12:48:20 +0200 [thread overview]
Message-ID: <1473331702-26711-5-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1473331702-26711-1-git-send-email-bgolaszewski@baylibre.com>
The chip_type variable in struct pca953x_chip is no longer required.
Remove it.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpio/gpio-pca953x.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 4c46cc8..02893c6 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -129,7 +129,6 @@ struct pca953x_chip {
struct i2c_client *client;
struct gpio_chip gpio_chip;
const char *const *names;
- int chip_type;
unsigned long driver_data;
const struct pca953x_reg_config *regs;
@@ -771,8 +770,6 @@ static int pca953x_probe(struct i2c_client *client,
}
}
- chip->chip_type = PCA_CHIP_TYPE(chip->driver_data);
-
mutex_init(&chip->i2c_lock);
/* initialize cached registers from their original values.
@@ -794,7 +791,7 @@ static int pca953x_probe(struct i2c_client *client,
chip->read_regs = pca953x_read_regs_16;
}
- if (chip->chip_type == PCA953X_TYPE)
+ if (PCA_CHIP_TYPE(chip->driver_data) == PCA953X_TYPE)
ret = device_pca953x_init(chip, invert);
else
ret = device_pca957x_init(chip, invert);
--
2.7.4
next prev parent reply other threads:[~2016-09-08 10:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 10:48 [PATCH v5 0/6] gpio: pca953x: code refactoring Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 1/6] gpio: pca953x: code shrink Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 2/6] gpio: pca953x: refactor pca953x_write_regs() Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 3/6] gpio: pca953x: refactor pca953x_read_regs() Bartosz Golaszewski
2016-09-08 10:48 ` Bartosz Golaszewski [this message]
2016-09-08 10:48 ` [PATCH v5 5/6] gpio: pca953x: coding style fixes Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 6/6] gpio: pca953x: make the define names consistent Bartosz Golaszewski
2016-09-08 12:27 ` Andy Shevchenko
2016-09-08 12:29 ` Bartosz Golaszewski
2016-09-08 12:29 ` Andy Shevchenko
2016-09-08 14:16 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473331702-26711-5-git-send-email-bgolaszewski@baylibre.com \
--to=bgolaszewski@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=geert+renesas@glider.be \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vigneshr@ti.com \
--cc=yong.b.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).