linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Vignesh R <vigneshr@ti.com>, Yong Li <yong.b.li@intel.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-gpio <linux-gpio@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v5 6/6] gpio: pca953x: make the define names consistent
Date: Thu,  8 Sep 2016 12:48:22 +0200	[thread overview]
Message-ID: <1473331702-26711-7-git-send-email-bgolaszewski@baylibre.com> (raw)
In-Reply-To: <1473331702-26711-1-git-send-email-bgolaszewski@baylibre.com>

The register offset defines for the pca953x and pca957x expander
families should have the same names to better reflect their similar
purposes.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 drivers/gpio/gpio-pca953x.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 71e1344..78ab25e 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -29,12 +29,12 @@
 
 #define REG_ADDR_AI		0x80
 
-#define PCA957X_IN		0
+#define PCA957X_INPUT		0
 #define PCA957X_INVRT		1
 #define PCA957X_BKEN		2
 #define PCA957X_PUPD		3
-#define PCA957X_CFG		4
-#define PCA957X_OUT		5
+#define PCA957X_DIRECTION	4
+#define PCA957X_OUTPUT		5
 #define PCA957X_MSK		6
 #define PCA957X_INTS		7
 
@@ -107,9 +107,9 @@ static const struct pca953x_reg_config pca953x_regs = {
 };
 
 static const struct pca953x_reg_config pca957x_regs = {
-	.direction = PCA957X_CFG,
-	.output = PCA957X_OUT,
-	.input = PCA957X_IN,
+	.direction = PCA957X_DIRECTION,
+	.output = PCA957X_OUTPUT,
+	.input = PCA957X_INPUT,
 };
 
 struct pca953x_chip {
@@ -699,10 +699,10 @@ static int device_pca957x_init(struct pca953x_chip *chip, u32 invert)
 
 	chip->regs = &pca957x_regs;
 
-	ret = pca953x_read_regs(chip, PCA957X_OUT, chip->reg_output);
+	ret = pca953x_read_regs(chip, PCA957X_OUTPUT, chip->reg_output);
 	if (ret)
 		goto out;
-	ret = pca953x_read_regs(chip, PCA957X_CFG, chip->reg_direction);
+	ret = pca953x_read_regs(chip, PCA957X_DIRECTION, chip->reg_direction);
 	if (ret)
 		goto out;
 
-- 
2.7.4

  parent reply	other threads:[~2016-09-08 10:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-08 10:48 [PATCH v5 0/6] gpio: pca953x: code refactoring Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 1/6] gpio: pca953x: code shrink Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 2/6] gpio: pca953x: refactor pca953x_write_regs() Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 3/6] gpio: pca953x: refactor pca953x_read_regs() Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 4/6] gpio: pca953x: remove an unused variable Bartosz Golaszewski
2016-09-08 10:48 ` [PATCH v5 5/6] gpio: pca953x: coding style fixes Bartosz Golaszewski
2016-09-08 10:48 ` Bartosz Golaszewski [this message]
2016-09-08 12:27   ` [PATCH v5 6/6] gpio: pca953x: make the define names consistent Andy Shevchenko
2016-09-08 12:29     ` Bartosz Golaszewski
2016-09-08 12:29     ` Andy Shevchenko
2016-09-08 14:16       ` Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473331702-26711-7-git-send-email-bgolaszewski@baylibre.com \
    --to=bgolaszewski@baylibre.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=geert+renesas@glider.be \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vigneshr@ti.com \
    --cc=yong.b.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).