linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/vc4: mark vc4_bo_cache_purge() static
@ 2016-09-08 11:03 Baoyou Xie
  2016-09-09 19:22 ` Eric Anholt
  0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-08 11:03 UTC (permalink / raw)
  To: eric, airlied; +Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou

We get 1 warning when building kernel with W=1:
drivers/gpu/drm/vc4/vc4_bo.c:147:6: warning: no previous prototype for 'vc4_bo_cache_purge' [-Wmissing-prototypes]

In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.

Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
 drivers/gpu/drm/vc4/vc4_bo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_bo.c b/drivers/gpu/drm/vc4/vc4_bo.c
index 59adcf8..3f6704c 100644
--- a/drivers/gpu/drm/vc4/vc4_bo.c
+++ b/drivers/gpu/drm/vc4/vc4_bo.c
@@ -144,7 +144,7 @@ static struct list_head *vc4_get_cache_list_for_size(struct drm_device *dev,
 	return &vc4->bo_cache.size_list[page_index];
 }
 
-void vc4_bo_cache_purge(struct drm_device *dev)
+static void vc4_bo_cache_purge(struct drm_device *dev)
 {
 	struct vc4_dev *vc4 = to_vc4_dev(dev);
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/vc4: mark vc4_bo_cache_purge() static
  2016-09-08 11:03 [PATCH] drm/vc4: mark vc4_bo_cache_purge() static Baoyou Xie
@ 2016-09-09 19:22 ` Eric Anholt
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Anholt @ 2016-09-09 19:22 UTC (permalink / raw)
  To: Baoyou Xie, airlied; +Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Baoyou Xie <baoyou.xie@linaro.org> writes:

> We get 1 warning when building kernel with W=1:
> drivers/gpu/drm/vc4/vc4_bo.c:147:6: warning: no previous prototype for 'vc4_bo_cache_purge' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>

Applied to -fixes.  Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-09 19:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 11:03 [PATCH] drm/vc4: mark vc4_bo_cache_purge() static Baoyou Xie
2016-09-09 19:22 ` Eric Anholt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).