* [PATCH] arm64: rockchip: fix i2c resource describe error of rk3368
@ 2016-09-08 11:03 Andy Yan
2016-09-08 14:29 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Andy Yan @ 2016-09-08 11:03 UTC (permalink / raw)
To: heiko
Cc: lorenzo.pieralisi, robh+dt, will.deacon, mark.rutland, jic23,
wxt, catalin.marinas, linux-arm-kernel, linux-kernel, devicetree,
Andy Yan
According to the TRM and downstream code from rockchip, the register
address of i2c1 on rk3368 is 0xff660000 and i2c2 is 0xff140000.
This patch fix the i2c1 & i2c2 register address definition error, also
fix the clk and pinctrl reference error.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
arch/arm64/boot/dts/rockchip/rk3368.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
index 0fcb214..2f8e19f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
@@ -315,16 +315,16 @@
status = "disabled";
};
- i2c1: i2c@ff140000 {
+ i2c2: i2c@ff140000 {
compatible = "rockchip,rk3368-i2c", "rockchip,rk3288-i2c";
reg = <0x0 0xff140000 0x0 0x1000>;
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
clock-names = "i2c";
- clocks = <&cru PCLK_I2C1>;
+ clocks = <&cru PCLK_I2C2>;
pinctrl-names = "default";
- pinctrl-0 = <&i2c1_xfer>;
+ pinctrl-0 = <&i2c2_xfer>;
status = "disabled";
};
@@ -554,16 +554,16 @@
status = "disabled";
};
- i2c2: i2c@ff660000 {
+ i2c1: i2c@ff660000 {
compatible = "rockchip,rk3368-i2c", "rockchip,rk3288-i2c";
reg = <0x0 0xff660000 0x0 0x1000>;
interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
clock-names = "i2c";
- clocks = <&cru PCLK_I2C2>;
+ clocks = <&cru PCLK_I2C1>;
pinctrl-names = "default";
- pinctrl-0 = <&i2c2_xfer>;
+ pinctrl-0 = <&i2c1_xfer>;
status = "disabled";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: rockchip: fix i2c resource describe error of rk3368
2016-09-08 11:03 [PATCH] arm64: rockchip: fix i2c resource describe error of rk3368 Andy Yan
@ 2016-09-08 14:29 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2016-09-08 14:29 UTC (permalink / raw)
To: Andy Yan
Cc: lorenzo.pieralisi, robh+dt, will.deacon, mark.rutland, jic23,
wxt, catalin.marinas, linux-arm-kernel, linux-kernel, devicetree
Am Donnerstag, 8. September 2016, 19:03:43 CEST schrieb Andy Yan:
> According to the TRM and downstream code from rockchip, the register
> address of i2c1 on rk3368 is 0xff660000 and i2c2 is 0xff140000.
>
> This patch fix the i2c1 & i2c2 register address definition error, also
> fix the clk and pinctrl reference error.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
after also checking the TRM for confirmation, applied to my dts64 branch
Thanks for catching that
Heiko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-08 14:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-08 11:03 [PATCH] arm64: rockchip: fix i2c resource describe error of rk3368 Andy Yan
2016-09-08 14:29 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).