* [PATCH -next] drm/tilcdc: Fix non static symbol warning
@ 2016-09-10 12:32 Wei Yongjun
2016-09-12 8:24 ` Jyri Sarha
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-09-10 12:32 UTC (permalink / raw)
To: Jyri Sarha, Tomi Valkeinen, David Airlie
Cc: Wei Yongjun, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning:
symbol 'tilcdc_atomic_check' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4405e4b..dc58770 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -61,8 +61,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
drm_fbdev_cma_hotplug_event(priv->fbdev);
}
-int tilcdc_atomic_check(struct drm_device *dev,
- struct drm_atomic_state *state)
+static int tilcdc_atomic_check(struct drm_device *dev,
+ struct drm_atomic_state *state)
{
int ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm/tilcdc: Fix non static symbol warning
2016-09-10 12:32 [PATCH -next] drm/tilcdc: Fix non static symbol warning Wei Yongjun
@ 2016-09-12 8:24 ` Jyri Sarha
0 siblings, 0 replies; 2+ messages in thread
From: Jyri Sarha @ 2016-09-12 8:24 UTC (permalink / raw)
To: Wei Yongjun, Tomi Valkeinen, David Airlie
Cc: Wei Yongjun, dri-devel, linux-kernel
On 09/10/16 15:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/tilcdc/tilcdc_drv.c:64:5: warning:
> symbol 'tilcdc_atomic_check' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I'll pick this up.
Thanks,
Jyri
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4405e4b..dc58770 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -61,8 +61,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device *dev)
> drm_fbdev_cma_hotplug_event(priv->fbdev);
> }
>
> -int tilcdc_atomic_check(struct drm_device *dev,
> - struct drm_atomic_state *state)
> +static int tilcdc_atomic_check(struct drm_device *dev,
> + struct drm_atomic_state *state)
> {
> int ret;
>
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-12 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-10 12:32 [PATCH -next] drm/tilcdc: Fix non static symbol warning Wei Yongjun
2016-09-12 8:24 ` Jyri Sarha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).