From: Laura Abbott <labbott@redhat.com>
To: Greg-KH <gregkh@linuxfoundation.org>
Cc: Laura Abbott <labbott@redhat.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>,
devel@driverdev.osuosl.org
Subject: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS
Date: Wed, 14 Sep 2016 08:33:58 -0700 [thread overview]
Message-ID: <1473867238-8801-1-git-send-email-labbott@redhat.com> (raw)
In-Reply-To: <a158a2b9-eb8e-2dcc-3625-e99337b95513@roeck-us.net>
The Ion platform code uses of_platform_device_create which has
dependencies on OF_ADDRESS. Depending on OF is not sufficient
Building sparc64:allmodconfig ... failed
--------------
Error log:
...
drivers/built-in.o: In function `ion_parse_dt':
(.text+0x11aa2c): undefined reference to `of_platform_device_create'
Add a dependency on OF_ADDRESS
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
Based on next-20160914
---
drivers/staging/android/ion/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
index 8a54ddc..9410554 100644
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
config ION_OF
bool "Devicetree support for Ion"
- depends on ION && OF
+ depends on ION && OF_ADDRESS
help
Provides base support for defining Ion heaps in devicetree
and setting them up. Also includes functions for platforms
--
2.7.4
next prev parent reply other threads:[~2016-09-14 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 21:31 Build error in -next due to ion patches when building sparc64:allmodconfig Guenter Roeck
2016-09-14 15:33 ` Laura Abbott [this message]
2016-09-14 16:25 ` [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Sumit Semwal
2016-09-14 20:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473867238-8801-1-git-send-email-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).