* Build error in -next due to ion patches when building sparc64:allmodconfig
@ 2016-09-13 21:31 Guenter Roeck
2016-09-14 15:33 ` [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Laura Abbott
0 siblings, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2016-09-13 21:31 UTC (permalink / raw)
To: Laura Abbott; +Cc: Greg Kroah-Hartman, linux-kernel
Hi Laura,
I see the following build error in -next.
Building sparc64:allmodconfig ... failed
--------------
Error log:
...
drivers/built-in.o: In function `ion_parse_dt':
(.text+0x11aa2c): undefined reference to `of_platform_device_create'
of_platform_device_create() depends on CONFIG_OF_ADDRESS, which is not
supported on sparc. Maybe add "depends on OF_ADDRESS" to the Kconfig file ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS
2016-09-13 21:31 Build error in -next due to ion patches when building sparc64:allmodconfig Guenter Roeck
@ 2016-09-14 15:33 ` Laura Abbott
2016-09-14 16:25 ` Sumit Semwal
2016-09-14 20:17 ` Guenter Roeck
0 siblings, 2 replies; 4+ messages in thread
From: Laura Abbott @ 2016-09-14 15:33 UTC (permalink / raw)
To: Greg-KH; +Cc: Laura Abbott, Guenter Roeck, linux-kernel, Sumit Semwal, devel
The Ion platform code uses of_platform_device_create which has
dependencies on OF_ADDRESS. Depending on OF is not sufficient
Building sparc64:allmodconfig ... failed
--------------
Error log:
...
drivers/built-in.o: In function `ion_parse_dt':
(.text+0x11aa2c): undefined reference to `of_platform_device_create'
Add a dependency on OF_ADDRESS
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
Based on next-20160914
---
drivers/staging/android/ion/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
index 8a54ddc..9410554 100644
--- a/drivers/staging/android/ion/Kconfig
+++ b/drivers/staging/android/ion/Kconfig
@@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
config ION_OF
bool "Devicetree support for Ion"
- depends on ION && OF
+ depends on ION && OF_ADDRESS
help
Provides base support for defining Ion heaps in devicetree
and setting them up. Also includes functions for platforms
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS
2016-09-14 15:33 ` [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Laura Abbott
@ 2016-09-14 16:25 ` Sumit Semwal
2016-09-14 20:17 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Sumit Semwal @ 2016-09-14 16:25 UTC (permalink / raw)
To: Laura Abbott; +Cc: Greg-KH, Guenter Roeck, LKML, devel
Hi Laura,
On 14 September 2016 at 21:03, Laura Abbott <labbott@redhat.com> wrote:
> The Ion platform code uses of_platform_device_create which has
> dependencies on OF_ADDRESS. Depending on OF is not sufficient
>
Thanks for the patch; looks good to me.
Please feel free to apply my
Reviewed-by: Sumit Semwal <sumit.semwal@linaro.org>
Best,
Sumit.
> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> ...
> drivers/built-in.o: In function `ion_parse_dt':
> (.text+0x11aa2c): undefined reference to `of_platform_device_create'
>
> Add a dependency on OF_ADDRESS
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> Based on next-20160914
> ---
> drivers/staging/android/ion/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 8a54ddc..9410554 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
>
> config ION_OF
> bool "Devicetree support for Ion"
> - depends on ION && OF
> + depends on ION && OF_ADDRESS
> help
> Provides base support for defining Ion heaps in devicetree
> and setting them up. Also includes functions for platforms
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS
2016-09-14 15:33 ` [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Laura Abbott
2016-09-14 16:25 ` Sumit Semwal
@ 2016-09-14 20:17 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2016-09-14 20:17 UTC (permalink / raw)
To: Laura Abbott; +Cc: Greg-KH, linux-kernel, Sumit Semwal, devel
On Wed, Sep 14, 2016 at 08:33:58AM -0700, Laura Abbott wrote:
> The Ion platform code uses of_platform_device_create which has
> dependencies on OF_ADDRESS. Depending on OF is not sufficient
>
> Building sparc64:allmodconfig ... failed
> --------------
> Error log:
> ...
> drivers/built-in.o: In function `ion_parse_dt':
> (.text+0x11aa2c): undefined reference to `of_platform_device_create'
>
> Add a dependency on OF_ADDRESS
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Tested-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Based on next-20160914
> ---
> drivers/staging/android/ion/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig
> index 8a54ddc..9410554 100644
> --- a/drivers/staging/android/ion/Kconfig
> +++ b/drivers/staging/android/ion/Kconfig
> @@ -43,7 +43,7 @@ source "drivers/staging/android/ion/hisilicon/Kconfig"
>
> config ION_OF
> bool "Devicetree support for Ion"
> - depends on ION && OF
> + depends on ION && OF_ADDRESS
> help
> Provides base support for defining Ion heaps in devicetree
> and setting them up. Also includes functions for platforms
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-14 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-13 21:31 Build error in -next due to ion patches when building sparc64:allmodconfig Guenter Roeck
2016-09-14 15:33 ` [PATCH] staging: android: ion: Make ION_OF depend on OF_ADDRESS Laura Abbott
2016-09-14 16:25 ` Sumit Semwal
2016-09-14 20:17 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).